From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Date: Sun, 01 Nov 2020 09:12:11 -0500 Message-ID: References: <83a6wip43q.fsf@gnu.org> <83sg9uhjy2.fsf@gnu.org> <835z6qgrwt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20234"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44070@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 15:13:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZE6d-0005CE-Ca for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 15:13:15 +0100 Original-Received: from localhost ([::1]:39156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZE6c-0007Sy-EX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 09:13:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZE6Q-0007RI-Pu for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52734) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZE6Q-0006on-G4 for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZE6Q-0003Wr-Be for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44070 X-GNU-PR-Package: emacs Original-Received: via spool by 44070-submit@debbugs.gnu.org id=B44070.160423994113496 (code B ref 44070); Sun, 01 Nov 2020 14:13:02 +0000 Original-Received: (at 44070) by debbugs.gnu.org; 1 Nov 2020 14:12:21 +0000 Original-Received: from localhost ([127.0.0.1]:36045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZE5l-0003Vc-83 for submit@debbugs.gnu.org; Sun, 01 Nov 2020 09:12:21 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZE5j-0003VI-6D for 44070@debbugs.gnu.org; Sun, 01 Nov 2020 09:12:19 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F1AB244089D; Sun, 1 Nov 2020 09:12:13 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A81F7440096; Sun, 1 Nov 2020 09:12:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604239932; bh=mnZiGc6/uvniIM0ZFB1tXrGlrwGcjvIkiPuosAuyMp0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Wm92GrFwkIQYr7PFkc5n7LxnOS/zL3YX0VMbkCfudk/et/w+yBNG99K8cDtL0+bMw 3p6HV8jtGpptJBCnbCkdgty6tiJPYzVFCm/Lyu0ksEauptOWRWiUWSHFAg6/C3JyY6 N9jE71s7K5oZNFWPgrGfuNGMP2IBnerE1ZFUi8klMCX6wj46epsX4t5/1kZeC1lAF4 955YKootJoM7bQ681o0giWOCVjGVFFrUL/CnRGaghF34jokWUTuqoP8SxvJN7KhEMN OuVK0i3lbnpXof9+Sc0xtjyQ8j1YzFoN8sreCQ9R3Mcw0Z2jzx56XAjis1r1dzFG/5 5CbWTjDd8/K6w== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6C93C1202DA; Sun, 1 Nov 2020 09:12:12 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Sun, 01 Nov 2020 08:29:09 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192377 Archived-At: >>> >> How 'bout the patch below, then? >>> > LGTM, modulo the NEWS and ELisp manual updates. >>> OK, thanks. Done and pushed. >> Actually, I see now that your changes only test that a window is a >> mini-window, but not that it displays a minibuffer. Did I miss >> something? If not, I'd prefer to add the conditions for displaying a >> minibuffer, okay? > How would I do that? Also, I'm not sure that's what we want to do: as I argued in my previous message, this change is mostly meant to better fit the behavior of resize_mini_window, and that behavior applies to all mini-windows, regardless if they're used for a minibuffer or something else. I suggest we keep the code as is for now, and we'll consider what to do *if* someone encounters a regression (which, for all we know, could also affect the minibuffer case). Stefan