From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#42406: Mouse-wheel scrolling can be flickering Date: Thu, 17 Dec 2020 18:24:26 -0500 Message-ID: References: <20200722201659.GA1541@breton.holly.idiocy.org> <969D8DEC-6837-4DD4-93E9-F359DADE1EAB@univie.ac.at> <20201010095100.GG60347@breton.holly.idiocy.org> <9849711D-8DBE-4030-8020-84D86E72505B@univie.ac.at> <83czzg3ge1.fsf@gnu.org> <83sg89cyrq.fsf@gnu.org> <837dpkcqpa.fsf@gnu.org> <32769197-17d3-564f-a917-c5e898f159b6@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28201"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: konrad.podczeck@univie.ac.at, Alan Third , 42406@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 18 00:25:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kq2eM-0007GY-Gu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 00:25:34 +0100 Original-Received: from localhost ([::1]:52508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kq2eL-0005E2-JQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Dec 2020 18:25:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kq2dq-0005Dq-Fq for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 18:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kq2dq-0001hk-7g for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 18:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kq2dq-0002ft-36 for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 18:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Dec 2020 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42406 X-GNU-PR-Package: emacs Original-Received: via spool by 42406-submit@debbugs.gnu.org id=B42406.160824747610230 (code B ref 42406); Thu, 17 Dec 2020 23:25:02 +0000 Original-Received: (at 42406) by debbugs.gnu.org; 17 Dec 2020 23:24:36 +0000 Original-Received: from localhost ([127.0.0.1]:37304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq2dQ-0002ew-2C for submit@debbugs.gnu.org; Thu, 17 Dec 2020 18:24:36 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq2dO-0002eb-DT for 42406@debbugs.gnu.org; Thu, 17 Dec 2020 18:24:35 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CCF0480A63; Thu, 17 Dec 2020 18:24:28 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 567DF80712; Thu, 17 Dec 2020 18:24:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608247467; bh=D8WQuujkB7kgG6O85ULDq9tjDO2kHd1E9upxtkUVEww=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YKbnQzyirKDi2jBYGWl0gG4qVb1qgLdgYVO2l7YrkDkRexm4GIsPFKl6b+dQdKHqm coe6NCOtKS8bMUGYfLwYe0YqWY7WC1HsAgKOF6KRGh3BYb+1bu/onZ2+BjG7rXMZ// ZBuEBDuWAEUlQp5nT82q1QNaGAK/cKnpKWE6/N6YoDGRWzbF6MOPnx7tFpeHFTj/bu RwkNhTTLKMJiF7rmfaQujoEm27p2yAKs4EBZFU1en7JckaFVKj2FmzrnlfNEMN5P1o 0A5JMSG1gAiBm4b/2m3ixXHTTV/2KtX3FDegEAmAXgkjqT3o7zt0EfdlJ8+Z8tWNEG xchpzIBGPxBsQ== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0B41E1203D8; Thu, 17 Dec 2020 18:24:26 -0500 (EST) In-Reply-To: <32769197-17d3-564f-a917-c5e898f159b6@gmx.at> (martin rudalics's message of "Fri, 18 Dec 2020 00:19:29 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196297 Archived-At: > Why penalize people with >= 2 windows per selected frame when scrolling > one of them by updating all the others' mode, header, tab lines? Because nobody implemented the code to optimize that extra work away. BTW, the patch below is what I use in my own branch now. Stefan diff --git a/src/window.c b/src/window.c index 20b0ef1525..c4f89b934e 100644 --- a/src/window.c +++ b/src/window.c @@ -224,7 +224,12 @@ wset_update_mode_line (struct window *w) Lisp_Object fselected_window = XFRAME (WINDOW_FRAME (w))->selected_window; if (WINDOWP (fselected_window) && XWINDOW (fselected_window) == w) - update_mode_lines = 42; + { + /* FIXME: This should be in xdisp.c, next to fset_redisplay + and friends! */ + update_mode_lines = 2; /* FIXME: REDISPLAY_SOME */ + XFRAME (WINDOW_FRAME (w))->redisplay = true; + } else w->update_mode_line = true; }