From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46243: [External] : Re: bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo Date: Wed, 03 Feb 2021 11:16:58 -0500 Message-ID: References: <83r1lz60so.fsf@gnu.org> <83a6sm5rlr.fsf@gnu.org> <83pn1h401u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32835"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46243@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 03 17:23:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7KwE-0008RY-6a for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Feb 2021 17:23:30 +0100 Original-Received: from localhost ([::1]:54386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7KwD-0007a7-8R for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Feb 2021 11:23:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7Kqw-0002Sc-EQ for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 11:18:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7Kqw-0001w9-6W for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 11:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7Kqw-0005ND-1V for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 11:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Feb 2021 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46243 X-GNU-PR-Package: emacs Original-Received: via spool by 46243-submit@debbugs.gnu.org id=B46243.161236902820567 (code B ref 46243); Wed, 03 Feb 2021 16:18:01 +0000 Original-Received: (at 46243) by debbugs.gnu.org; 3 Feb 2021 16:17:08 +0000 Original-Received: from localhost ([127.0.0.1]:38684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7Kq3-0005Lf-N3 for submit@debbugs.gnu.org; Wed, 03 Feb 2021 11:17:07 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7Kq2-0005L3-Fo for 46243@debbugs.gnu.org; Wed, 03 Feb 2021 11:17:06 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1677144098A; Wed, 3 Feb 2021 11:17:01 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6985E440958; Wed, 3 Feb 2021 11:16:59 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612369019; bh=oK2vu2JqWxNm8iJV0bngB0Czk4nk2ETUg7iHx5SLbMw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QwDdp5MIvBudjiSptNDyr+YJfPtyY8axw9+ORvi0pETsQGUzgQxQf9uG248vxCkkC QLAgDSb0Hra05tqSpv9TSkJneQp6guL98I5Js9l9sqC/Z5xHcKcK22NBgYJAi5jJ+u tZQlG4x4ooY7VchQ7uagtjLq9o/fIE1YLHOfH6+6ZIwhjkSgz88G7SUrLLbUhA47vE X34UcEEmo5zRbsRsRzlvuB8dMrBwS+lsSAFjoL0xAwpzOx3GypMWW74C6TpzHcNmOX MPmuAdUCRKy7On+Wnu++i5M4NulVs9O5rJ7TPlUXzldeJbNw/NoV8GzXhvRHUWVlcT 0t648cJn1wvPw== Original-Received: from alfajor (76-10-182-85.dsl.teksavvy.com [76.10.182.85]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 21A98120270; Wed, 3 Feb 2021 11:16:59 -0500 (EST) In-Reply-To: <83pn1h401u.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 Feb 2021 17:56:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199211 Archived-At: > This is a consequence of fixing bug#15332. CC'ing Stefan, who both > reported the bug and installed the fix. > Stefan, the change you made to fix that bug, viz.: > > diff --git a/src/keyboard.c b/src/keyboard.c > index 440820c..020c885 100644 > --- a/src/keyboard.c > +++ b/src/keyboard.c > @@ -2596,10 +2596,8 @@ read_char (int commandflag, Lisp_Object map, > > if (/* There currently is something in the echo area. */ > !NILP (echo_area_buffer[0]) > - && (/* And it's either not from echoing. */ > - !EQ (echo_area_buffer[0], echo_message_buffer) > - /* Or it's an echo from a different kboard. */ > - || echo_kboard != current_kboard > + && (/* It's an echo from a different kboard. */ > + echo_kboard != current_kboard > /* Or we explicitly allow overwriting whatever there is. */ > || ok_to_echo_at_next_pause == NULL)) > cancel_echoing (); > else > echo_dash (); > > is what's causing this one: where we previously called cancel_echoing, > because !EQ (echo_area_buffer[0], echo_message_buffer) was true, we > now call echo_dash, because the remaining 2 conditions are false. > > The change you installed is not explained, so I cannot reason about > the importance of echo_message_buffer. Do you remember why you > decided to remove that 3rd condition? I don't think I understood the echo-keystrokes code very back then and I still don't understand it very much either. This fixed the problem, but I'm not sure why. I just tried to revert this change and it does re-introduce part of the problem mentioned in bug#15332: C-u [..wait..] 5 gives me immediately `C-u 5-` in the echo area whereas C-u [..wait..] 5 5 only shows `C-u 55-` after the `echo-keystrokes` delay. Stefan