From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Sat, 29 May 2021 09:59:01 -0400 Message-ID: References: <83tunj651i.fsf@gnu.org> <83lf8u68bu.fsf@gnu.org> <83mtta4gtf.fsf@gnu.org> <83fsz24f2x.fsf@gnu.org> <83v97x2xum.fsf@gnu.org> <83bl9nevd3.fsf@gnu.org> <831rad5t18.fsf@gnu.org> <835yz26jdk.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40872"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ioannis Kappas , 48137@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 29 16:00:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmzVc-000ATg-5C for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 16:00:12 +0200 Original-Received: from localhost ([::1]:53922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmzVb-0006R0-7n for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 10:00:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmzVS-0006Qr-Tz for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 10:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmzVS-00022z-MU for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 10:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmzVS-0005FT-Jp for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 10:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 May 2021 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.162229675220089 (code B ref 48137); Sat, 29 May 2021 14:00:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 29 May 2021 13:59:12 +0000 Original-Received: from localhost ([127.0.0.1]:57462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmzUd-0005Dx-Pd for submit@debbugs.gnu.org; Sat, 29 May 2021 09:59:11 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmzUb-0005Dh-Dx for 48137@debbugs.gnu.org; Sat, 29 May 2021 09:59:11 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BE9A5804FD; Sat, 29 May 2021 09:59:03 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 69B688040B; Sat, 29 May 2021 09:59:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622296742; bh=AUJSWV0PHlmztSG68c/qFcFJ7jjNQbVAkPn/OQYgI2M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Vzm+B/ubfX2Kab+pfIurUVQA6vyOxEBSdhwwZmvdD8sL4WPFagonr9T0xth01pgKd Q2UQZ9wqlervEjC6+ofDp/EGj9FfUuOywm6KucyvLrYTpVvtGK7R8AG0W7xVBG01Mv vxN1LVvr9bZ6183reaeSmBUDePbFkgc1ukYr4kYAkTShfosdJuwzLp/ZgOFDhe3Pbx AGQxIcdlvmUWJKwDYJyqVdG3BL3wkKiFyNBpGL2a408yU4BTQTs2qnV034o8UvBnxQ PG2EVjdAXKGoBYafUfNU27WgfVfkFW0qRAaNlKLjPIf9aTqs41Ynl/AD9GXvY7I9Rk z67WcmkJMWfgw== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1BCAE120FAB; Sat, 29 May 2021 09:59:02 -0400 (EDT) In-Reply-To: <835yz26jdk.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 May 2021 11:20:55 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207534 Archived-At: >> From: Ioannis Kappas >> Date: Sun, 16 May 2021 10:09:07 +0100 >> Cc: Stefan Monnier , 48137@debbugs.gnu.org >> >> On Sat, May 15, 2021 at 2:52 PM Ioannis Kappas wrote: >> > I shall have a look next whether we could always load the package with >> > `insert-file-contents-literally' but parse headers with the correct >> > encoding (`find-operation-coding-system' looks like a promising fn >> > to determine the correct encoding from a literal file buffer). >> >> Please find below a patch to read package headers from a temporarily >> decoded buffer, while keeping the literal buffer (which will be used >> to install the package) intact. > > Stefan, any comments? No particular comment from me, except: this is tricky enough that it would benefit from some regression tests. Stefan