From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62762: 'make' often errors with "Org version mismatch" after pulling a new version of the code Date: Sat, 22 Apr 2023 10:32:50 -0400 Message-ID: References: <17b74a48-94e1-9106-cc79-d31972313910@gutov.dev> <837cujaqzq.fsf@gnu.org> <87wn2ilwed.fsf@localhost> <83zg7ealrd.fsf@gnu.org> <87pm8a8dx4.fsf@localhost> <8335569rs7.fsf@gnu.org> <87jzyi8cu2.fsf@localhost> <83wn2i8bht.fsf@gnu.org> <875ya18oaz.fsf@localhost> <83zg7d78wv.fsf@gnu.org> <87fs94faes.fsf@localhost> <83zg7c41qq.fsf@gnu.org> <87h6tjeuei.fsf@localhost> <83o7nr4yrp.fsf@gnu.org> <87a5zb7rgu.fsf@localhost> <83pm85ctf5.fsf@gnu.org> <83edod4fzw.fsf@gnu.org> <87r0sdp859.fsf@localhost> <83o7ng1c1p.fsf@gnu.org> <878rekum41.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26349"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: bzg@gnu.org, dmitry@gutov.dev, Eli Zaretskii , 62762@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 22 16:34:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqEJg-0006fw-W3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Apr 2023 16:34:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqEJT-0001YB-Mf; Sat, 22 Apr 2023 10:34:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqEJP-0001Xq-6q for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 10:34:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqEJO-0007aa-OK for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 10:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqEJO-0004w6-Dl for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 10:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2023 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62762 X-GNU-PR-Package: emacs Original-Received: via spool by 62762-submit@debbugs.gnu.org id=B62762.168217398618907 (code B ref 62762); Sat, 22 Apr 2023 14:34:02 +0000 Original-Received: (at 62762) by debbugs.gnu.org; 22 Apr 2023 14:33:06 +0000 Original-Received: from localhost ([127.0.0.1]:43793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqEIT-0004ut-Li for submit@debbugs.gnu.org; Sat, 22 Apr 2023 10:33:05 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqEIQ-0004uM-Hc for 62762@debbugs.gnu.org; Sat, 22 Apr 2023 10:33:04 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 448734412C0; Sat, 22 Apr 2023 10:32:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7ADA6440A5F; Sat, 22 Apr 2023 10:32:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1682173971; bh=Ty6gcTkqDb/8tnU9NoK3FFY7AYgjDSd39CH2nw3HVBg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bkE+iwojWcoSTN7THuPq5TXhZttBgzkT5BGoQhkUdleMa2JF5qV5G1NoeYckDy3ff PPP53l8LOA3C5kKWdzZWSIjHXAyk1nABRltIP2AzHBTeXQPsaZ3S/OBEMaR8ly9WS9 Kz+NVItcNt7TJsbDSp2xKhch5xWdLDSpxoJG0qCfE6fwZWD/sgNN0iRWFJzSsyrSU6 X0X/BsKpOXjXsCBxFIqb2QFlcEBjLSAP6HCLnerzAjxzQ+CXdV8PM1gDZItN1BU0Or cdkBz25aYHWwDxx33e5WA0u3e/B/CU4ZEfk07saZL7ZsNp2O8/lz/jHmmAdgIRp2Lp 40OTj7otspizA== Original-Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 27240120315; Sat, 22 Apr 2023 10:32:51 -0400 (EDT) In-Reply-To: <878rekum41.fsf@localhost> (Ihor Radchenko's message of "Sat, 22 Apr 2023 12:39:42 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260478 Archived-At: Ihor Radchenko [2023-04-22 12:39:42] wrote: > Eli Zaretskii writes: > >> I think it's the defconst thingy. E.g., with foo.el which says >> >> (defconst my-foo nil) >> >> I cannot override the value from the command line: >> >> emacs -Q -batch --eval "(setq my-foo t)" -l foo.el --eval "(message \"%s\" my-foo)" >> => nil >> >> But if I replace defconst with defvar, it yields t, as I'd expect. >> >> So I think org--built-in-p should be a defvar, not defconst. Or maybe >> you can teach me how to override a defconst? Stefan, any ideas? > > Well. I think I missed that `defconst', unlike `defvar', overrides the > existing variable value. Switching to `defvar' is ok. (Or, it might be > something like (eval-after-load 'org-macs ...), but I see no reason to > prefer it over switching to defvar). > > I think it will be best to install the change in Emacs and then back-port > it to Org. Will it be ok? While you're there: could you rename that var? I think it should be called `org--inhibit-version-check` (no "-p" since it's a var and not a predicate, and more importantly no ill-defined notion of "built-in"). Stefan