From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Gemini Lasswell <gazally@runbox.com>, 64536@debbugs.gnu.org
Subject: bug#64536: 30.0.50; Make cl-print put buttons on ellipses
Date: Sat, 12 Aug 2023 01:23:03 -0400 [thread overview]
Message-ID: <jwvbkfcu9r2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87msyyt3oo.fsf@localhost> (Ihor Radchenko's message of "Fri, 11 Aug 2023 07:53:59 +0000")
>> -;; Define button type used for ...'s.
>> -;; Set skip property so you don't have to TAB through 100 of them to
>> -;; get to the next function name.
>> -(define-button-type 'backtrace-ellipsis
>> - 'skip t 'action #'backtrace-expand-ellipsis
>> - 'help-echo "mouse-2, RET: expand this ellipsis")
>
> Isn't this a breaking change?
> I just got inspector.el broken because it uses 'backtrace-ellipsis
> button type.
Apparently it's a breaking change, indeed.
Hmm... we could re-add it, but with the new `cl-print.el` your code
should simply not use `backtrace-ellipsis` at all because `cl-print.el`
did it for you already.
IOW, I think a patch like the one below my sig is the better option.
> At least, I'd expect to see the removal documented in NEWS.
How 'bout:
The code that allowed "..." to be expanded in the "*Backtrace*" buffer
should now work anywhere the data is generated by 'cl-print'.
+*** The 'backtrace-ellipsis' button is replaced by 'cl-print-ellipsis'.
+
*** hash-tables' contents can be expanded via the ellipsis.
+*** Modes can control the expansion via 'cl-print-expand-ellipsis-function'.
+
** Modeline elements can now be right-aligned.
Anything following the symbol 'mode-line-format-right-align' in
'mode-line-format' will be right-aligned. Exactly where it is
-- Stefan
diff --git a/inspector.el b/inspector.el
index fa9b1cc778..e00209f2be 100644
--- a/inspector.el
+++ b/inspector.el
@@ -1,6 +1,6 @@
;;; inspector.el --- Tool for inspection of Emacs Lisp objects -*- lexical-binding: t -*-
-;; Copyright (C) 2021-2022 Free Software Foundation, Inc.
+;; Copyright (C) 2021-2023 Free Software Foundation, Inc.
;; Author: Mariano Montone <marianomontone@gmail.com>
;; URL: https://github.com/mmontone/emacs-inspector
@@ -243,13 +243,14 @@ LIMIT controls the truncation."
(put-text-property (point-min) (point) 'inspector-form (gensym))
;; Make buttons from all the "..."s. Since there might be many of
;; them, use text property buttons.
- (goto-char (point-min))
- (while (< (point) (point-max))
- (let ((end (next-single-property-change (point) 'cl-print-ellipsis
- nil (point-max))))
- (when (get-text-property (point) 'cl-print-ellipsis)
- (make-text-button (point) end :type 'backtrace-ellipsis))
- (goto-char end)))
+ (unless (boundp 'cl-print-expand-ellipsis-function) ;Emacs-30
+ (goto-char (point-min))
+ (while (< (point) (point-max))
+ (let ((end (next-single-property-change (point) 'cl-print-ellipsis
+ nil (point-max))))
+ (when (get-text-property (point) 'cl-print-ellipsis)
+ (make-text-button (point) end :type 'backtrace-ellipsis))
+ (goto-char end))))
(buffer-string)))
(cl-defgeneric inspector--face-for-object (object)
next prev parent reply other threads:[~2023-08-12 5:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 4:42 bug#64536: 30.0.50; Make cl-print put buttons on ellipses Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-13 23:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-11 7:53 ` Ihor Radchenko
2023-08-12 5:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-12 8:39 ` Ihor Radchenko
2023-08-12 18:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-13 9:26 ` Ihor Radchenko
2023-08-13 16:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-14 11:01 ` Ihor Radchenko
2023-08-14 14:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-14 15:15 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbkfcu9r2.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=64536@debbugs.gnu.org \
--cc=gazally@runbox.com \
--cc=monnier@iro.umontreal.ca \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).