From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Thu, 23 Nov 2023 11:24:59 -0500 Message-ID: References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31773"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jens Schmidt , 67005@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 23 17:26:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6CWu-00083R-4u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Nov 2023 17:26:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6CWe-00006D-LB; Thu, 23 Nov 2023 11:26:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6CWc-00005e-K7 for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 11:25:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6CWc-0005gr-C0 for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 11:25:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6CWg-0004VA-8v for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 11:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Nov 2023 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.170075671217234 (code B ref 67005); Thu, 23 Nov 2023 16:26:02 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 23 Nov 2023 16:25:12 +0000 Original-Received: from localhost ([127.0.0.1]:34845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6CVr-0004Tt-Tu for submit@debbugs.gnu.org; Thu, 23 Nov 2023 11:25:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6CVq-0004Tf-1f for 67005@debbugs.gnu.org; Thu, 23 Nov 2023 11:25:10 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B50731000AD; Thu, 23 Nov 2023 11:25:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700756699; bh=LxaJiTWQ8t3Vt7WIaU3I3zjvn1Yg+/LIaxDjSfXMxmc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QwLvrJ66K9/3WVNQKJfAM2MbadhsmH9ABz4YI43sxk5vqr8/szyEpRoueAm2fTEwq JkTV7i/OhSo4H0V3EVmIEwz+s6wRm7DnDJbr6dN2elg4KzJ6uK4VcXZmN+DECYGm59 UqU7UnJ2yg0zIC0osPlQFg4xTL2ZxExJG8Nezho52xSA0zE3rtpSrz4uZi+I4XK5av ZzwuTzu7e8Duid/RiJZ+ymPdpiqOB4am0306ut43XuPQLhnNnLZuwrwCxjOEOQG63t zNinBFbKqj2Nhb0ay9urnx8dSs1asgsjaHVeyivX3vaBeBCTIgfRfU81J1uTf/PyrZ JFyEh/FAV7HXw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DD8F5100043; Thu, 23 Nov 2023 11:24:59 -0500 (EST) Original-Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BA7D4120324; Thu, 23 Nov 2023 11:24:59 -0500 (EST) In-Reply-To: (Andrea Corallo's message of "Thu, 23 Nov 2023 10:00:19 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274815 Archived-At: >> + (when purify-flag >> + (error "Invalid pre-dump advice on %s" symbol)) >> (let* ((f (symbol-function symbol)) >> (nf (advice--normalize symbol f))) >> (unless (eq f nf) (fset symbol nf)) > > The patch LGTM thanks, just one question: should we guard in advice.el > as well just to stay on the safe side? Since `defadvice` is now marked as obsolete, it seems highly unlikely that we'd end up adding an old-style advice to a preloaded file. But this reminds me that some people do their own preload/dump, sometimes with a crapload of extra packages, in which case the probability that some of them use advice-add is rather high. IIUC the the above `error` is not technically indispensable (the code will still work mostly right, beside some issues about the docstrings that affect only actual C-code subrs and not native-compiled subrs), so it would be better to demote the above `error` to a warning. Stefan