From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74735: 31.0.50; Commit 986621ae1ff4d3cfad31adb20216f1f71ce0747c broke org-ql Date: Fri, 13 Dec 2024 17:21:07 -0500 Message-ID: References: <87r06i8m8v.fsf@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8923"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74735@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 13 23:22:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tME3C-0002BU-Sp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Dec 2024 23:22:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tME30-0006Jw-DM; Fri, 13 Dec 2024 17:22:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tME2s-0006Jd-TZ for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 17:22:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tME2s-0000GZ-JW for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 17:22:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Q5kMiBCpJjROIXaeSYA8r2m+DVT7BGbruPDT8aZ90Yg=; b=JeBGkWN24BprBsFkD7cQbMkikL/6Nhvi7yAPbcDf20jTVBP5MJk3X2WXhZEPKDlhZGotnN/qiJAlKrJ0XB5h+k+MlDQ30Q0r4yWa/51PjloEtdGRz+JQUg4oSLWyyjImoCT9dT+Grj2a0J1QDydWzF7GOfvw4h5M8clxfgRvewH0O78neVFuCR9IhLsGhFPh/GKdZAx8MfHZssPtCajOMGWlh20UxLqGTV7cAfSC4AJ/BmvRuWl+TlfZhyEEjmLGDXLb4AB8w8QJyk2aIhcVgUj+tDpfgyJVe0IAByYRuHXcjO1NOieYzYfXvkGniwOvl52dZLaFToxXMwP+N+Ebuw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tME2r-0007sB-Tw for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 17:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2024 22:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74735 X-GNU-PR-Package: emacs Original-Received: via spool by 74735-submit@debbugs.gnu.org id=B74735.173412848530186 (code B ref 74735); Fri, 13 Dec 2024 22:22:01 +0000 Original-Received: (at 74735) by debbugs.gnu.org; 13 Dec 2024 22:21:25 +0000 Original-Received: from localhost ([127.0.0.1]:44484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tME2H-0007qo-1i for submit@debbugs.gnu.org; Fri, 13 Dec 2024 17:21:25 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tME2E-0007qT-D8 for 74735@debbugs.gnu.org; Fri, 13 Dec 2024 17:21:23 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2397A10004A; Fri, 13 Dec 2024 17:21:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1734128468; bh=X0odgkY1gyZdU5P1LL9yiZ4STB/zwpBMc2jbic7exDk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DwMgpUFjO9Xmt9NOJPzce5YEpd4BpaoPWgpAlcXZERYSwgXRoFEyo7Kav1I1L+fmA nhJWKQXLkHnnq0sHMtaRhsTZ3Ota7Yms+/VSOpA4vLrkQXwTgrxC++I9D42nnrfHwT 02dYXe1g3OSfrzgux6vF+chhN5Iq4EzXo8qfEHphuvTpWgDR4nV7lnMR1NAQjEhrYR jasm7hhipVLHK7SOpbzkohBEycTiZEu6CkyHqzdjiJLhPY4+ZkreCJcgug6+Pu7COe aPBolYHqo7a6EaT/3vcjVw5kg2aNbkDTwBTUjxoZ7U3oiH4WKdZo+0H372Ch2XGwX9 bcQraQv3/x3kQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9AC11100042; Fri, 13 Dec 2024 17:21:08 -0500 (EST) Original-Received: from alfajor (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 46F5012049E; Fri, 13 Dec 2024 17:21:08 -0500 (EST) In-Reply-To: <87r06i8m8v.fsf@gmail.com> (Visuwesh's message of "Sun, 08 Dec 2024 16:39:20 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296995 Archived-At: --=-=-= Content-Type: text/plain > The recent change you made in > > commit 986621ae1ff4d3cfad31adb20216f1f71ce0747c > Author: Stefan Monnier > Date: Tue Nov 12 23:12:07 2024 -0500 > > (with-peg-rules): Build proper `peg-function`s > > * lisp/progmodes/peg.el (with-peg-rules): Use the new (FUNC EXP) > feature in `cl-labels`. > > broke org-ql's PEG parser. I tried to reproduce it with the number > parser example given in the Elisp Info manual but failed. With the > above change, I get an assertion error when I try to use org-ql-find: > > Debugger entered--Lisp error: (cl-assertion-failed (lexical-binding nil)) Thanks. Until this is fixed on `master`, the patch below will fix `org-ql` to use lexical-binding for that code (like it already does for all the rest of the code). [ It also removes a NUL byte from the file which caused some tools to treat it as a binary file. ] Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=org-ql.patch Content-Transfer-Encoding: 8bit diff --git a/org-ql.el b/org-ql.el index f3b7715..654da49 100644 --- a/org-ql.el +++ b/org-ql.el @@ -863,7 +863,7 @@ respectively." (zero-or-more (not (any "\n\":")))) (zero-or-more (not (any "\n\":"))))) (group (zero-or-more (not (any "\n")))) "\n" - (63 (group (*\? (not (any "