From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to Date: Tue, 10 Feb 2009 20:45:31 -0500 Message-ID: References: <36366a980902091937x40e025cbm6b351ab4620d6281@mail.gmail.com> Reply-To: Stefan Monnier , 2259@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1234317881 30035 80.91.229.12 (11 Feb 2009 02:04:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Feb 2009 02:04:41 +0000 (UTC) Cc: 2259@emacsbugs.donarmstrong.com, Eric Hanchrow To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 11 03:05:56 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LX4TH-0000XA-W3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Feb 2009 03:05:12 +0100 Original-Received: from localhost ([127.0.0.1]:46347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LX4Ry-0007oC-Cj for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Feb 2009 21:03:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LX4Rt-0007nH-Sg for bug-gnu-emacs@gnu.org; Tue, 10 Feb 2009 21:03:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LX4Rt-0007n2-6N for bug-gnu-emacs@gnu.org; Tue, 10 Feb 2009 21:03:37 -0500 Original-Received: from [199.232.76.173] (port=32839 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LX4Rs-0007mn-QM for bug-gnu-emacs@gnu.org; Tue, 10 Feb 2009 21:03:36 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42793) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LX4Rs-0003NB-1Q for bug-gnu-emacs@gnu.org; Tue, 10 Feb 2009 21:03:36 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1B23X8W006801; Tue, 10 Feb 2009 18:03:33 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1B1t6cF004528; Tue, 10 Feb 2009 17:55:06 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 11 Feb 2009 01:55:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2259 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Original-Received: via spool by 2259-submit@emacsbugs.donarmstrong.com id=B2259.12343167402661 (code B ref 2259); Wed, 11 Feb 2009 01:55:06 +0000 Original-Received: (at 2259) by emacsbugs.donarmstrong.com; 11 Feb 2009 01:45:40 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1B1jbr0002645 for <2259@emacsbugs.donarmstrong.com>; Tue, 10 Feb 2009 17:45:38 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArEEADC8kUlFxIvi/2dsb2JhbACBbtFxhBoGgyM X-IronPort-AV: E=Sophos;i="4.38,188,1233550800"; d="scan'208";a="33694772" Original-Received: from 69-196-139-226.dsl.teksavvy.com (HELO pastel.home) ([69.196.139.226]) by ironport2-out.teksavvy.com with ESMTP; 10 Feb 2009 20:45:31 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8E2D27FE6; Tue, 10 Feb 2009 20:45:31 -0500 (EST) In-Reply-To: (Juanma Barranquero's message of "Tue, 10 Feb 2009 17:10:20 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 10 Feb 2009 21:03:37 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25138 Archived-At: > OK, I see now that "ENV should be in the same format as > `process-environment'", and that, in `process-environment', "[e]ach > element should be a string of the form ENVVARNAME=VALUE". So yes, it > is known that there shouldn't be negative entries, and it is even > documented. > Still, perhaps this change would be useful... Yes, it looks good, Stefan