From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kzhr@d1.dion.ne.jp, 7848@debbugs.gnu.org
Subject: bug#7848: 23.2.91; Can't build with MinGW
Date: Sun, 16 Jan 2011 10:21:53 -0500 [thread overview]
Message-ID: <jwvaaj0swsk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1PePSk-0005gL-5l@fencepost.gnu.org> (Eli Zaretskii's message of "Sun, 16 Jan 2011 05:03:54 -0500")
>> I would recommend to stay away from such low-level code unless you're
>> writing code that tries to implement part of the binding-semantics
>> of Emacs. I.e. just use Fset.
> Using Fset here would be a terrible overkill, IMO.
Overkill? For code that's not even inside a loop? What are you talking about?
> I'm not even sure I understand all of its semantics,
The semantics of Fset are the same as the ones of `setq' which you use
days-in days-out in Elisp. I.e. it's the semantics you know best,
whereas the semantics of SET_SYMBOL_VAL are a lot more tricky.
> and not sure it will work correctly in the context of an init_*
> function that is called when Emacs is dumped.
Yes, it'll work just fine, pretty much in any context (the only tricky
context in this respect is when/before the `nil' symbol&variable and the
`unbound' value are built, AFAIK).
> OTOH, direct assignments of symbol's value like above _are_
> used in several init_* functions and elsewhere.
I've fixed some of those in the past, and feel free to fix more of them.
> Also, I wanted to un-break the release branch as fast as I could.
I'm not complaining, at all. Just giving advice.
Stefan
next prev parent reply other threads:[~2011-01-16 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 7:34 bug#7848: 23.2.91; Can't build with MinGW Kazuhiro Ito
2011-01-16 0:41 ` Eli Zaretskii
2011-01-16 4:41 ` Stefan Monnier
2011-01-16 10:03 ` Eli Zaretskii
2011-01-16 15:21 ` Stefan Monnier [this message]
2011-01-16 15:58 ` Eli Zaretskii
2011-01-16 6:16 ` Kazuhiro Ito
2011-01-16 9:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvaaj0swsk.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7848@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kzhr@d1.dion.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).