unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: Charles Magid <cmmagid@gmail.com>, 11134@debbugs.gnu.org
Subject: bug#11134: 24.0.94; Mac's Text to Speech stopped working in emacs buffers when I moved	from Snow Leopard to Lion
Date: Sun, 01 Apr 2012 09:26:03 -0400	[thread overview]
Message-ID: <jwvaa2v4miz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <wlr4w8f8s0.wl%mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Sun, 01 Apr 2012 12:09:03 +0900")

>> The NS port does not support accessability at all, but if it is the
>> function described by YAMAMOTO Mitsuharu above you want, try the
>> patch below.
>> +  else if ([attribute isEqualToString:NSAccessibilityValueAttribute])
>> +    {
>> +      if (! NILP (BVAR (current_buffer, mark_active)))
>> +        str = ns_get_local_selection (QPRIMARY, QUTF8_STRING);
>> +      if (NILP (str))
>> +        str = Fbuffer_string ();
>> +    }
> Is it safe to call Fbuffer_string (in particular, move the gap) inside
> read_socket_hook?  It is apparently unsafe without SYNC_INPUT, but I'm
> not sure if it is supposed to be OK for the SYNC_INPUT case.

Indeed without SYNC_INPUT it's clearly unsafe (not just because of
move_gap).

And to tell you the truth, I'm not sure either what is safe with
SYNC_INPUT and what isn't.

This said, it shouldn't be difficult to change make_buffer_string_both
such that it doesn't need to move the gap, at which point I think it
would be OK.


        Stefan





  parent reply	other threads:[~2012-04-01 13:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 18:09 bug#11134: 24.0.94; Mac's Text to Speech stopped working in emacs buffers when I moved from Snow Leopard to Lion Charles Magid
2012-03-31  0:54 ` YAMAMOTO Mitsuharu
2012-03-31  5:44   ` Eli Zaretskii
2012-03-31 14:34   ` Jan Djärv
2012-04-01  3:09     ` YAMAMOTO Mitsuharu
2012-04-01  9:10       ` Jan Djärv
2012-04-01 22:50         ` YAMAMOTO Mitsuharu
2012-04-01 13:26       ` Stefan Monnier [this message]
2012-07-21 11:23 ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvaa2v4miz.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=11134@debbugs.gnu.org \
    --cc=cmmagid@gmail.com \
    --cc=mituharu@math.s.chiba-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).