From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11517: 24.0.97; invalid compilation error regexp for maven Date: Mon, 21 May 2012 00:26:30 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337574459 27476 80.91.229.3 (21 May 2012 04:27:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 May 2012 04:27:39 +0000 (UTC) Cc: 11517@debbugs.gnu.org To: cinsky@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 21 06:27:38 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SWKDT-0004PS-Bw for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2012 06:27:31 +0200 Original-Received: from localhost ([::1]:39862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWKDS-0002fA-RK for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2012 00:27:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWKDQ-0002eq-D9 for bug-gnu-emacs@gnu.org; Mon, 21 May 2012 00:27:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWKDO-0005gj-JH for bug-gnu-emacs@gnu.org; Mon, 21 May 2012 00:27:27 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWKDO-0005gT-Ff for bug-gnu-emacs@gnu.org; Mon, 21 May 2012 00:27:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SWKDx-0001bn-OI for bug-gnu-emacs@gnu.org; Mon, 21 May 2012 00:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 May 2012 04:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11517 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11517-submit@debbugs.gnu.org id=B11517.13375744536145 (code B ref 11517); Mon, 21 May 2012 04:28:01 +0000 Original-Received: (at 11517) by debbugs.gnu.org; 21 May 2012 04:27:33 +0000 Original-Received: from localhost ([127.0.0.1]:36064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SWKDU-0001b3-Kn for submit@debbugs.gnu.org; Mon, 21 May 2012 00:27:32 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:6410) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SWKDA-0001aY-Ra for 11517@debbugs.gnu.org; Mon, 21 May 2012 00:27:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmgFAOMAh0/O+K+j/2dsb2JhbAA3oRSCLoEIgXUBAQQBViMFCws0EhQYDYg3ohGMIkIMA4M+AxBCgx4Eo2OEWA X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="181546722" Original-Received: from 206-248-175-163.dsl.teksavvy.com (HELO ceviche.home) ([206.248.175.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 May 2012 00:26:31 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8A8B3660E0; Mon, 21 May 2012 00:26:30 -0400 (EDT) In-Reply-To: (cinsky@gmail.com's message of "Sat, 19 May 2012 15:29:59 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60254 Archived-At: > Example maven error from: > [ERROR] /Users/cinsk/hello.java:[651,96] ';' expected > ^^^^^^^^^^^^^^^^^^^^^^^^ Hmm... the current maven regexp doesn't make much sense (it has a special [0-9]* at the beginning which doesn't seem to make any difference, other than make the regexp more complex, obviously). But more importantly, it does not try to match a "[ERROR]". The current tests we have just include: ;; maven ("FooBar.java:[111,53] no interface expected here" 1 53 111 "FooBar.java") > (maven "^\\[ERROR\\] +\\(.+?\\):\\[\\([0-9]+\\),\\([0-9]+\\)\\].*" > 1 2 2) This doesn't match the string we have in our current test, tho. The patch below seems to fix it for your example. Please try it out, Stefan === modified file 'lisp/progmodes/compile.el' --- lisp/progmodes/compile.el 2012-05-18 01:46:20 +0000 +++ lisp/progmodes/compile.el 2012-05-21 03:44:37 +0000 @@ -209,7 +209,7 @@ ;; due to matching filenames via \\(.*?\\). This might be faster. (maven ;; Maven is a popular free software build tool for Java. - "\\([0-9]*[^0-9\n]\\(?:[^\n :]\\| [^-/\n]\\|:[^ \n]\\)*?\\):\\[\\([0-9]+\\),\\([0-9]+\\)\\] " 1 2 3) + "\\([^ \n]\\(?:[^\n :]\\| [^-/\n]\\|:[^ \n]\\)*?\\):\\[\\([0-9]+\\),\\([0-9]+\\)\\] " 1 2 3) (jikes-line "^ *\\([0-9]+\\)\\.[ \t]+.*\n +\\(<-*>\n\\*\\*\\* \\(?:Error\\|Warnin\\(g\\)\\)\\)"