From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10624: Dired-marking all files in the region Date: Thu, 22 Nov 2012 10:40:36 -0500 Message-ID: References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com> <60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com> <87392k2ml9.fsf@mail.jurta.org> <4200B2318C4140E68FA74B61375885B9@us.oracle.com> <87sjaj2atc.fsf@mail.jurta.org> <96319E709DC548DBADB263DA2DD11A82@us.oracle.com> <87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1353598916 5667 80.91.229.3 (22 Nov 2012 15:41:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Nov 2012 15:41:56 +0000 (UTC) Cc: 10624@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 22 16:42:07 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TbYui-0001La-SD for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Nov 2012 16:42:04 +0100 Original-Received: from localhost ([::1]:59634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbYuY-0004sf-D8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Nov 2012 10:41:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbYuS-0004rC-0t for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2012 10:41:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbYuM-0006re-83 for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2012 10:41:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbYuM-0006ra-4e for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2012 10:41:42 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TbYve-0004Rg-KX for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2012 10:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Nov 2012 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10624-submit@debbugs.gnu.org id=B10624.135359892617021 (code B ref 10624); Thu, 22 Nov 2012 15:43:02 +0000 Original-Received: (at 10624) by debbugs.gnu.org; 22 Nov 2012 15:42:06 +0000 Original-Received: from localhost ([127.0.0.1]:33319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbYuj-0004QT-Q8 for submit@debbugs.gnu.org; Thu, 22 Nov 2012 10:42:06 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:5046) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbYud-0004Q1-3B for 10624@debbugs.gnu.org; Thu, 22 Nov 2012 10:41:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FpaQ6/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="208223519" Original-Received: from 69-165-164-58.dsl.teksavvy.com (HELO pastel.home) ([69.165.164.58]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Nov 2012 10:40:37 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 616CF597C9; Thu, 22 Nov 2012 10:40:36 -0500 (EST) In-Reply-To: <87ehjmrmzg.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 22 Nov 2012 11:49:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67315 Archived-At: > is to add an `interactive' arg (there were some reasons not to use > (called-interactively-p 'interactive) but I forgot the exact reasons). One of the main reasons is reliability. If you look at the code of called-interactively-p, you'll see it's pretty hackish, so it's easy to break it. For example `called-interactively-p' may fail to work correctly in the following known cases: - when the function is advised (this was recently improved, so it will now fail sometimes rather than always). - when inside a condition-case or catch in lexical-binding code. - when inside a `pcase' branch (because pcase sometimes moves the branch to a lambda in order to avoid duplicating the code). Another reason is that it makes it more flexible for non-interactive callers, which can control whether to run the function "as if the arguments had been provided interactively". `called-interactively-p' is handy when you can't add an argument, but otherwise it's much better to add an `interactive' argument. Stefan