From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14925: 24.3.50; `image-dired.el' code (minor) Date: Thu, 25 Jul 2013 15:13:00 -0400 Message-ID: References: <6a9c11fa-71ad-44f9-9771-35626a56ee01@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1374779655 28360 80.91.229.3 (25 Jul 2013 19:14:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Jul 2013 19:14:15 +0000 (UTC) Cc: 14925@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 25 21:14:15 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V2QzM-0006G7-5z for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2013 21:14:12 +0200 Original-Received: from localhost ([::1]:56638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2QzL-0001AW-Nz for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2013 15:14:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2QzE-00010H-5t for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2013 15:14:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2QzC-0007jb-Rn for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2013 15:14:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2QzC-0007jX-PI for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2013 15:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V2QzC-0006ni-8i for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2013 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2013 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14925 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14925-submit@debbugs.gnu.org id=B14925.137477958825998 (code B ref 14925); Thu, 25 Jul 2013 19:14:02 +0000 Original-Received: (at 14925) by debbugs.gnu.org; 25 Jul 2013 19:13:08 +0000 Original-Received: from localhost ([127.0.0.1]:49698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V2QyK-0006lB-3b for submit@debbugs.gnu.org; Thu, 25 Jul 2013 15:13:08 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:43372) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V2QyI-0006kQ-VJ for 14925@debbugs.gnu.org; Thu, 25 Jul 2013 15:13:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rw3N/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFG4rw3N/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="19834421" Original-Received: from 184-175-13-205.dsl.teksavvy.com (HELO pastel.home) ([184.175.13.205]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Jul 2013 15:12:54 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B084866BA0; Thu, 25 Jul 2013 15:13:00 -0400 (EDT) In-Reply-To: <6a9c11fa-71ad-44f9-9771-35626a56ee01@default> (Drew Adams's message of "Sun, 21 Jul 2013 12:37:24 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76654 Archived-At: > 1. `image-dired-dired-file-marked-p' uses regexp "^ .*$", which I think > is the same as "^ " (which is simpler). It's similar, except for (match-end 0) and the position of point after re-search-forward. I haven't looked at the code to see if the difference matters. > I also wonder why it does not just use `dired-re-mark'. No idea. > 2. Commands that act on the marked files should perhaps follow the > naming convention used in dired.el, dired-aux.el, and dired-x.el: > `*-do-*'. Thus perhaps rename `image-dired-dired-comment-files', > `image-dired-tag-files', `image-dired-delete-tag', > `image-dired-display-thumbs', `image-dired-copy-with-exif-file-name', > `image-dired-dired-edit-comment-and-tags', and > `image-dired-create-thumbs'. > The equivalent Dired command that acts on the current file only, when > available, is named similarly, but without the `*-do-*' part. > 3. Those commands do not treat parameter ARG the same way as do the > Dired `*-do-*' commands. For the image-dired commands, ARG is > essentially boolean (and should thus have a name that reflects that). > Wouldn't it be better for it to be the `prefix-numeric-value' and let > you act on the next ARG files? That would give users more flexibility > and provide a more consistent UI. Is there a downside I am missing? 2 and 3 sound like good ideas. Stefan