From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3984: Date: Wed, 18 Sep 2013 23:38:48 -0400 Message-ID: References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> <5233670E.4030703@thompsonclan.org> <5237C9FF.1000809@thompsonclan.org> <52388FEB.6020007@thompsonclan.org> <523A37A4.5060505@thompsonclan.org> <523A49BE.3060109@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1379562021 14822 80.91.229.3 (19 Sep 2013 03:40:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 03:40:21 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Ryan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 19 05:40:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMV6L-0008T0-9v for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Sep 2013 05:40:21 +0200 Original-Received: from localhost ([::1]:49527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMV6K-0004Z0-U3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Sep 2013 23:40:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMV6B-0004YL-A7 for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2013 23:40:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMV63-00068Z-RZ for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2013 23:40:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMV63-00066u-Ot for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2013 23:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VMV62-0001In-Ha for bug-gnu-emacs@gnu.org; Wed, 18 Sep 2013 23:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2013 03:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.13795619434909 (code B ref 3984); Thu, 19 Sep 2013 03:40:02 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 19 Sep 2013 03:39:03 +0000 Original-Received: from localhost ([127.0.0.1]:47982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMV53-0001Go-PY for submit@debbugs.gnu.org; Wed, 18 Sep 2013 23:39:02 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:47998) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMV51-0001GY-Sw for 3984@debbugs.gnu.org; Wed, 18 Sep 2013 23:39:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFsoX0U/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFFsoX0U/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="28331202" Original-Received: from 108-161-125-20.dsl.teksavvy.com (HELO pastel.home) ([108.161.125.20]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 18 Sep 2013 23:35:00 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B2D46666B7; Wed, 18 Sep 2013 23:38:48 -0400 (EDT) In-Reply-To: <523A49BE.3060109@thompsonclan.org> (Ryan's message of "Wed, 18 Sep 2013 17:47:58 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78550 Archived-At: > advice. This is what "advice--called-interactively-skip" does. (Although > reading through it I don't see where the bug is that prevents it recognizing > the before advice in my example.) Exactly. I think we need to fix this problem. It really should work. > If all advised functions are wrapped by a call to the above function > "wrap-function-in-indicator-lambda", All functions advised with a non-:around advice have such a "recognizable wrapper"; and that's indeed what advice--called-interactively-skip checks in (and (eq (nth 1 frame2) 'apply) (progn (funcall get-next-frame) (advice--p (indirect-function (nth 1 frame2))))) IOW the nadvice.el machinery is itself the recognizable wrapper. Not sure why this fails in your test case, tho. For :around advices, the machinery does not provide a recognizable wrapper, so we might want to add an ad-hoc wrapper like you suggest for those cases, tho maybe we can avoid the cost of such a wrapper, by keeping the so-advised inner-functions in a hash-table (so we can still recognize them, even tho they're not tagged directly in the backtrace). So, I think the first thing is to figure out why your test case fails. Stefan