From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Date: Wed, 04 Dec 2013 12:57:38 -0500 Message-ID: References: <87vbz5zcxv.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386179895 12000 80.91.229.3 (4 Dec 2013 17:58:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Dec 2013 17:58:15 +0000 (UTC) Cc: 16035@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 04 18:58:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VoGiK-0007tF-1y for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Dec 2013 18:58:20 +0100 Original-Received: from localhost ([::1]:49663 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoGiJ-0005Vl-QG for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Dec 2013 12:58:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoGiA-0005VQ-0R for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 12:58:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoGi2-0003DU-NH for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 12:58:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoGi2-0003DQ-K4 for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 12:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VoGi2-0004lO-Cw for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 12:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Dec 2013 17:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16035 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16035-submit@debbugs.gnu.org id=B16035.138617986218277 (code B ref 16035); Wed, 04 Dec 2013 17:58:02 +0000 Original-Received: (at 16035) by debbugs.gnu.org; 4 Dec 2013 17:57:42 +0000 Original-Received: from localhost ([127.0.0.1]:58284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VoGhh-0004ki-JS for submit@debbugs.gnu.org; Wed, 04 Dec 2013 12:57:42 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:22982) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VoGhg-0004kY-2E for 16035@debbugs.gnu.org; Wed, 04 Dec 2013 12:57:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxL6g/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kLodwBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av8EABK/CFFFxL6g/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kLodwBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="41133542" Original-Received: from 69-196-190-160.dsl.teksavvy.com (HELO pastel.home) ([69.196.190.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Dec 2013 12:57:38 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8B3DF60045; Wed, 4 Dec 2013 12:57:38 -0500 (EST) In-Reply-To: (Anders Lindgren's message of "Wed, 4 Dec 2013 12:48:52 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81382 Archived-At: > I tried you solution and it works perfectly! Just make sure to save the > keymap after the call to "(run-hooks 'isearch-mode-hook)", as this is where > packages like "folding" installs its keymap. Great to hear. Juri, can you do that for me? > While looking around the isearch code, I came up with a theory why > multi-buffer search in change-log-mode no longer works. isearch adds its > hook to the LOCAL pre-command-hook. As change-log-mode search change buffer > and the hook is not installed in the new buffer, the user can't exit > isearch. Sounds right, as well. Juri, can you take care of that while you're at it? BTW, Anders, I see you have signed more paperwork for Emacs than pretty much anybody else, yet none of them covers changes to isearch.el. If I were you, I'd sign a general assignment for all of Emacs and be done with it once and for all. If that's OK with you, then just tell me and I'll send you the relevant info, Stefan