From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16617: 24.3.50; REGRESSION: `C-q ?' pops up annoying *Char Help* buffer Date: Thu, 19 Jun 2014 11:43:20 -0400 Message-ID: References: <891cf052-6085-4ad4-b03b-83379a85ff0f@default> <7367bf77-7602-4a02-82ce-804c2f88bf25@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1403192673 7754 80.91.229.3 (19 Jun 2014 15:44:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Jun 2014 15:44:33 +0000 (UTC) Cc: 16617@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 19 17:44:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WxeVk-0002Ya-K2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Jun 2014 17:44:24 +0200 Original-Received: from localhost ([::1]:36351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxeVk-0006bh-7T for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Jun 2014 11:44:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxeVZ-0006a1-9l for bug-gnu-emacs@gnu.org; Thu, 19 Jun 2014 11:44:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxeVQ-00024p-Sw for bug-gnu-emacs@gnu.org; Thu, 19 Jun 2014 11:44:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxeVQ-00024i-P0 for bug-gnu-emacs@gnu.org; Thu, 19 Jun 2014 11:44:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WxeVP-0002VX-SL for bug-gnu-emacs@gnu.org; Thu, 19 Jun 2014 11:44:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jun 2014 15:44:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16617 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16617-submit@debbugs.gnu.org id=B16617.14031926129576 (code B ref 16617); Thu, 19 Jun 2014 15:44:03 +0000 Original-Received: (at 16617) by debbugs.gnu.org; 19 Jun 2014 15:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:53336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxeUt-0002UN-DO for submit@debbugs.gnu.org; Thu, 19 Jun 2014 11:43:31 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:35673) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxeUp-0002U4-54 for 16617@debbugs.gnu.org; Thu, 19 Jun 2014 11:43:28 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="68275256" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Jun 2014 11:43:21 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id DF1BD60D16; Thu, 19 Jun 2014 11:43:20 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Thu, 03 Apr 2014 21:34:07 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90556 Archived-At: > Can I fix it in emacs-24 along these lines? Thanks. - Leo Yes, please. Stefan > === modified file 'lisp/simple.el' > --- lisp/simple.el 2014-04-02 15:14:50 +0000 > +++ lisp/simple.el 2014-04-03 13:31:12 +0000 > @@ -658,11 +658,17 @@ > The optional argument PROMPT specifies a string to use to prompt the user. > The variable `read-quoted-char-radix' controls which radix to use > for numeric input." > - (let ((message-log-max nil) done (first t) (code 0) translated) > + (let ((message-log-max nil) > + (help-events (delq nil (mapcar (lambda (c) (unless (characterp c) c)) > + help-event-list))) > + done (first t) (code 0) translated) > (while (not done) > (let ((inhibit-quit first) > - ;; Don't let C-h get the help message--only help function keys. > + ;; Don't let C-h or other help chars get the help > + ;; message--only help function keys. See bug#16617. > (help-char nil) > + (help-event-list help-events) > (help-form > "Type the special character you want to use, > or the octal character code.