From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: 19613@debbugs.gnu.org
Subject: bug#19613: 25.0.50; cl-labels bug
Date: Mon, 26 Jan 2015 10:14:56 -0500 [thread overview]
Message-ID: <jwva915o9qx.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <b4mbnlmqe1u.fsf@jpl.org> (Katsumi Yamaoka's message of "Mon, 26 Jan 2015 14:57:49 +0900")
> - (let ((found (assq f macroexpand-all-environment)))
> - (if (and found (ignore-errors
> - (eq (cadr (cl-caddr found)) 'cl-labels-args)))
> - (cadr (cl-caddr (cl-cadddr found)))
> + (let* ((found (assq f macroexpand-all-environment))
> + (replacement (and found
> + (ignore-errors
> + (funcall (cdr found) cl--labels-magic)))))
> + (if (and replacement (eq cl--labels-magic (car replacement)))
> + (nth 1 replacement)
> (let ((res `(function ,f)))
> (setq cl--function-convert-cache (cons f res))
> res))))))
This looks correct. Ideally this part of cl--function-convert should
delegate to cl--labels-convert to avoid the code duplication, tho.
Stefan
next prev parent reply other threads:[~2015-01-26 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 5:19 bug#19613: 25.0.50; cl-labels bug Katsumi Yamaoka
2015-01-16 14:50 ` Stefan Monnier
2015-01-16 20:09 ` Glenn Morris
2015-01-17 3:57 ` Stefan Monnier
2015-01-22 7:07 ` Katsumi Yamaoka
2015-01-26 5:57 ` Katsumi Yamaoka
2015-01-26 15:14 ` Stefan Monnier [this message]
2015-01-26 23:00 ` Katsumi Yamaoka
2015-01-26 23:25 ` Katsumi Yamaoka
2015-01-27 2:06 ` Stefan Monnier
2015-01-27 3:16 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva915o9qx.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=19613@debbugs.gnu.org \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).