unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24749@debbugs.gnu.org
Subject: bug#24749: Making sure syntax-propertize is called
Date: Fri, 21 Oct 2016 12:34:27 -0400	[thread overview]
Message-ID: <jwva8dxvf4v.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <834m45snaf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Oct 2016 19:02:32 +0300")

>> >> Nowadays, syntax-propertize is automatically called ondemand by the sexp
>> >> functions, but only if parse-sexp-lookup-properties is non-nil.
>> >> See bug#4920 for an example of the problem and the fix we installed.
>> >> I suggest we install the patch below instead, so as to fix this bug in
>> >> more/all major modes at once.
>> > Since when does this issue exist?
>> 25.1.
> Then I'm okay with having this on the emacs-25 branch, thanks.

I think I may have described it incorrectly: the issue that it solves is
one that's been around forever.  It's just that 25.1 fixes this issue in
most cases and hence creates a new expectations that the issue is fixed,
but there's still a hole if you try to use navigation commands before
any syntax-propertize call, which this patch intends to fix.

So I don't think this is urgent, and since the fix (whichever we choose)
affects (by nature) "all" modes, I don't think it's safe enough for
emacs-25.


        Stefan





  reply	other threads:[~2016-10-21 16:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20 21:14 bug#24749: Making sure syntax-propertize is called Stefan Monnier
2016-10-20 22:31 ` Dmitry Gutov
2016-10-20 23:12   ` Stefan Monnier
2016-10-21 15:58     ` Dmitry Gutov
2016-10-21  6:56 ` Eli Zaretskii
2016-10-21 15:36   ` Stefan Monnier
2016-10-21 16:02     ` Eli Zaretskii
2016-10-21 16:34       ` Stefan Monnier [this message]
2016-10-21 17:27         ` Eli Zaretskii
2017-12-12  2:03           ` Noam Postavsky
2017-12-12 14:12             ` Stefan Monnier
     [not found] ` <handler.24749.D24749.151308794732170.notifdone@debbugs.gnu.org>
2017-12-12 17:54   ` bug#24749: closed (Re: bug#24749: Making sure syntax-propertize is called) Tassilo Horn
2017-12-12 19:45     ` Stefan Monnier
     [not found]     ` <jwv4lovu3xj.fsf-monnier+emacs@gnu.org>
2017-12-13  8:50       ` martin rudalics
     [not found] ` <87ef4awyb6.fsf@gmail.com>
     [not found]   ` <jwvblzewpgj.fsf-monnier+emacs@gnu.org>
2019-06-03 17:47     ` bug#24749: Making sure syntax-propertize is called Stefan Monnier
2019-06-03 19:25       ` Vitalie Spinu
2019-06-03 19:45         ` Stefan Monnier
2019-06-03 20:04           ` npostavs
2019-06-04  5:49           ` Vitalie Spinu
2019-06-04 13:08             ` Stefan Monnier
2019-06-05  5:25               ` Vitalie Spinu
2019-06-05 13:32                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva8dxvf4v.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=24749@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).