From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Leo Liu <sdl.web@gmail.com>
Cc: 25280@debbugs.gnu.org
Subject: bug#25280: 25.1; define-inline doesn't support &rest
Date: Tue, 27 Dec 2016 12:42:44 -0500 [thread overview]
Message-ID: <jwva8bh8emi.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <jwvshp98kxg.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Tue, 27 Dec 2016 10:25:25 -0500")
>> (let ((x 1) (y 2)) (princ (rest x y))) ; B
>> So A prints [1 2] and B [x y] i.e. x y is not eval'd. thoughts?
> Hmm... indeed... and it breaks down even with (rest (+ x 1) y).
Wait, I was confused: `xs` is a list of expressions, so of course ', is
not the right way to place it in there. To turn it into an expression
that evaluates to a list of values, you generally want (list . ,xs):
(define-inline sm-foo (&rest xs)
(inline-letevals xs (inline-quote (apply #'vector (list . ,xs)))))
and I think this works correctly.
OTOH it's not as efficient as we'd like. The better way to write it is:
(define-inline sm-foo (&rest xs)
(inline-letevals xs (inline-quote (vector . ,xs))))
but I now see that this is not handled properly in the case the function
is not inlined. More specifically, the `sm-foo` function gets defined as:
(lambda (&rest xs) (apply vector xs))
where the `vector` failed to be quoted with #'.
I installed the patch below into `master` which should fix it.
Stefan
diff --git a/lisp/emacs-lisp/inline.el b/lisp/emacs-lisp/inline.el
index 058c56c3b49..5ceb0d9ed29 100644
--- a/lisp/emacs-lisp/inline.el
+++ b/lisp/emacs-lisp/inline.el
@@ -191,9 +191,9 @@ After VARS is handled, BODY is evaluated in the new environment."
(while (and (consp exp) (not (eq '\, (car exp))))
(push (inline--dont-quote (pop exp)) args))
(setq args (nreverse args))
- (if exp
- `(apply ,@args ,(inline--dont-quote exp))
- args)))
+ (if (null exp)
+ args
+ `(apply #',(car args) ,@(cdr args) ,(inline--dont-quote exp)))))
(_ exp)))
(defun inline--do-leteval (var-exp &rest body)
next prev parent reply other threads:[~2016-12-27 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 2:42 bug#25280: 25.1; define-inline doesn't support &rest Leo Liu
2016-12-27 3:21 ` Stefan Monnier
2016-12-27 4:25 ` Leo Liu
2016-12-27 15:25 ` Stefan Monnier
2016-12-27 17:42 ` Stefan Monnier [this message]
2016-12-29 2:00 ` Leo Liu
2016-12-29 2:41 ` Leo Liu
2016-12-29 3:25 ` Stefan Monnier
2016-12-29 5:54 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva8bh8emi.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=25280@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).