From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#33170: 27.0.50; interactive spec with cl-defgeneric/method Date: Tue, 30 Oct 2018 08:48:49 -0400 Message-ID: References: <87efccmjun.fsf@gmail.com> <83lg6jop6b.fsf@gnu.org> <87k1m3lg0k.fsf@gmail.com> <83woq3mopc.fsf@gnu.org> <87d0rva1fx.fsf@gmail.com> <83r2gbmksh.fsf@gnu.org> <877ei0n8du.fsf@gmail.com> <838t2floza.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540903633 2658 195.159.176.226 (30 Oct 2018 12:47:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 12:47:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alex Branham , 33170-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 30 13:47:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHTQK-0000aE-Pe for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Oct 2018 13:47:08 +0100 Original-Received: from localhost ([::1]:53026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHTSR-0000Uo-9n for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Oct 2018 08:49:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHTSB-0000QS-AJ for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 08:49:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHTSA-0008Pa-Hb for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 08:49:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHTSA-0008PU-Cw for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 08:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gHTSA-0004Ac-9d for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 08:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Oct 2018 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33170 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33170-done@debbugs.gnu.org id=D33170.154090373416014 (code D ref 33170); Tue, 30 Oct 2018 12:49:02 +0000 Original-Received: (at 33170-done) by debbugs.gnu.org; 30 Oct 2018 12:48:54 +0000 Original-Received: from localhost ([127.0.0.1]:53506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHTS2-0004AD-1d for submit@debbugs.gnu.org; Tue, 30 Oct 2018 08:48:54 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHTRz-0004A5-Fp for 33170-done@debbugs.gnu.org; Tue, 30 Oct 2018 08:48:52 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w9UCmncd016728; Tue, 30 Oct 2018 08:48:50 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8ADDF6A445; Tue, 30 Oct 2018 08:48:49 -0400 (EDT) In-Reply-To: <838t2floza.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Oct 2018 12:15:37 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6407=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6407> : inlines <6947> : streams <1802810> : uri <2741052> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151825 Archived-At: >> Thanks for the response. Seems like the two-function solution is the way >> to go I guess. I do think this should be documented as a limitation >> somewhere though. > Done. Should we add a warning for it? Stefan diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el index fb4f3ab680..025653de70 100644 --- a/lisp/emacs-lisp/cl-generic.el +++ b/lisp/emacs-lisp/cl-generic.el @@ -355,6 +355,9 @@ cl-generic-define-context-rewriter . ,(lambda () spec-args)) macroexpand-all-environment))) (require 'cl-lib) ;Needed to expand `cl-flet' and `cl-function'. + (when (interactive-form (cadr fun)) + (message "Interactive forms unsupported in generic functions: %S" + (interactive-form (cadr fun)))) ;; First macroexpand away the cl-function stuff (e.g. &key and ;; destructuring args, `declare' and whatnot). (pcase (macroexpand fun macroenv)