From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#35381: 26.2; nxml-mode doesn't fontify attributes in single quotes Date: Wed, 24 Apr 2019 10:52:01 -0400 Message-ID: References: <87imv6rpig.fsf@gmail.com> <87v9z4qjit.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222177"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35381@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 24 17:02:04 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJJPQ-000vYu-Au for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 17:02:04 +0200 Original-Received: from localhost ([127.0.0.1]:43010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJJPN-0005me-Ob for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 11:02:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJJPB-0005Q9-1s for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 11:01:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJJGf-0000j8-Ts for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 10:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42630) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJJGf-0000j1-Qy for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 10:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJJGf-0004In-Js for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 10:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2019 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35381 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35381-submit@debbugs.gnu.org id=B35381.155611752516471 (code B ref 35381); Wed, 24 Apr 2019 14:53:01 +0000 Original-Received: (at 35381) by debbugs.gnu.org; 24 Apr 2019 14:52:05 +0000 Original-Received: from localhost ([127.0.0.1]:56172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJJFk-0004Ha-Uq for submit@debbugs.gnu.org; Wed, 24 Apr 2019 10:52:05 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:57424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJJFj-0004HS-4M for 35381@debbugs.gnu.org; Wed, 24 Apr 2019 10:52:03 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3OEq1aY026823; Wed, 24 Apr 2019 10:52:01 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1CBE26AE07; Wed, 24 Apr 2019 10:52:01 -0400 (EDT) In-Reply-To: <87v9z4qjit.fsf@gmail.com> (Noam Postavsky's message of "Tue, 23 Apr 2019 21:28:10 -0400") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6532=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6532> : inlines <7059> : streams <1819598> : uri <2836531> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158180 Archived-At: > Well, I was pretty sure that XML allows both quotes, but just to make > things definitive, https://www.w3.org/TR/xml/#NT-AttValue: > > [10] AttValue ::= '"' ([^<&"] | Reference)* '"' > | "'" ([^<&'] | Reference)* "'" Thanks for checking. > I didn't actually checkout and compile before+after, but I'm pretty sure > it's [56e1097584], same as Bug#32003. > > [56e1097584]: 2016-01-16 15:03:42 -0500 > lisp/nxml: Use syntax-tables for comments > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=56e1097584c13f2b6db85592769db1c6c36e9419 Ah, yes, that makes sense. > s/more/equally/, but otherwise yes. Patching sgml-mode is shorter and > even fixes Bug#8203 as well. Still good for emacs-26 I hope, since this > is for an (nxml-mode) regression in 26.1. Great, thanks. > --- a/lisp/textmodes/sgml-mode.el > +++ b/lisp/textmodes/sgml-mode.el > @@ -103,7 +103,7 @@ (defcustom sgml-mode-hook nil > ;; As long as Emacs's syntax can't be complemented with predicates to context > ;; sensitively confirm the syntax of characters, we have to live with this > ;; kludgy kind of tradeoff. > -(defvar sgml-specials '(?\") > +(defvar sgml-specials '(?\" ?\') > "List of characters that have a special meaning for SGML mode. > This list is used when first loading the `sgml-mode' library. > The supported characters and potential disadvantages are: I think this "disadvantages" part of the docstring is out of date. Can you update it while you're at it? Also, we probably want to mark this var as obsolete. Stefan