From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#36447: 27.0.50; New "Unknown keyword" errors Date: Fri, 05 Jul 2019 16:21:41 -0400 Message-ID: References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="175068"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 05 22:51:48 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjVBL-000jP1-DB for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 22:51:47 +0200 Original-Received: from localhost ([::1]:56058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjVBK-0005Yf-D6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 16:51:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33885) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjUiZ-0003IM-BU for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 16:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjUiY-0001rC-Dj for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 16:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45016) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjUiY-0001qi-AC for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 16:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjUiY-0008Bv-5b for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 16:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2019 20:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36447 X-GNU-PR-Package: emacs Original-Received: via spool by 36447-submit@debbugs.gnu.org id=B36447.156235811731470 (code B ref 36447); Fri, 05 Jul 2019 20:22:02 +0000 Original-Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 20:21:57 +0000 Original-Received: from localhost ([127.0.0.1]:53836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjUiS-0008BV-VS for submit@debbugs.gnu.org; Fri, 05 Jul 2019 16:21:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjUiR-0008B6-3S for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 16:21:55 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C4C5A81181; Fri, 5 Jul 2019 16:21:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 57C8D810B1; Fri, 5 Jul 2019 16:21:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562358103; bh=0Yj4aF4cZlk/LPy4eTa4lkXSkGd2abxAwAh1xI4Dbts=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QGTqTSKopnxIBi0TiHbokfTWyyMV3F5Zwbe+RFIbmWa8OLhlc0ihMqTrSaD0bMVsl SJbzl/4Vn5GkzhBp4s8vd86oS/HMQ/OsnTJYZJMuFBBpj9CnFsWfBfBGahQXbw3myq yXDpsicqjswn/Q1P6fzsIFluSN/twgR7FmAT+PjQ5XX/cJnTJHkVDpeKVSHJNbJ+8t 1Jsj8njpotCOhzjaXRdfAfDEnNzkQbusjjulJ4Zly8h1IYZx12fvnwjbIIrSbjFFEC wnOHog4KqUojoLJlk4a4eWqbyH2jf3EAzphw931UlFoFB6/bJ9k/c/FlDwnxmvDRj8 wQpDFqqDrQrtw== Original-Received: from alfajor (76-10-138-228.dsl.teksavvy.com [76.10.138.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 013DC1201D0; Fri, 5 Jul 2019 16:21:42 -0400 (EDT) In-Reply-To: (Pip Cet's message of "Fri, 5 Jul 2019 18:57:56 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162163 Archived-At: >> His patch can/should be made slightly more efficient by only doing the >> Fcopy_sequence on those hash-tables that are in purespace. > > How do we test for that? With PURE_P? > I'm not sure how difficult it would be, but we could dump the ->index, > ->next, ->hash vectors as Qnil (so not include the actual vectors in > the dump), which would make the dump slightly smaller and give us a > better test than h->count < 0: Except that it can't be done at the time of purecopy but only at the time we do the actual dump because the purecopied hashtable may be used in-between (which is also why count is kept positive by purecopy and is only made negative later). > Slightly contrived problem here: if the single key in a single-entry > EQ hash is -7, or an expression that happens to have hash value -1, > pure->hash and pure->next would be EQ after these two lines, and > updating the hash would corrupt the hash table... Indeed. As I said, I think your approach is better, I only included it for reference and for the comments I had added. Stefan