unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: alan@idiocy.org, konrad.podczeck@univie.ac.at, 42406@debbugs.gnu.org
Subject: bug#42406: Mouse-wheel scrolling can be flickering
Date: Thu, 17 Dec 2020 14:45:19 -0500	[thread overview]
Message-ID: <jwva6ucw7pq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83im9070x6.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Dec 2020 20:16:53 +0200")

> force-mode-line-update should only be needed when changes in the mode
> line are displayed in the middle of running Lisp code.

I think the calls to `force-mode-line-update` in minor mode functions
beg to disagree.  E.g.

    src/emacs -Q --eval '(global-set-key "a" (lambda () (interactive) (setq abbrev-mode (not abbrev-mode))))'

you'll notice that hitting `a` doesn't change the mode line to reflect
the change in `abbrev-mode`.

> We should stop lumping heuristics one on top another, and instead
> redesign this from scratch and make sure that every flag we set is
> acted upon as intended, and only in situations we intend them to be
> acted upon.  E.g., we should be able to set f->redisplay to a value
> that means "update only the frame title".

The `redisplay` bit is not supposed to be a heuristic at all.  It just
tried to keep track more precisely of which part of the redisplay may
have changed.  `fset_redisplay` marks the frame to be redisplayed at the
next redisplay, setting `update_mode_lines` to a non-zero value means
that when redisplaying a window we also redisplay its mode line, so
the suggested hunk definitely doesn't rely on any kind of heuristic.

[ Any chance you got confused thinking that my patch intended to
  stop updating the column/line numbers in frame titles?
  It's most definitely not: the "This said" in my message divides two
  different proposed ways to attack the problem.  ]

The main problems I see with my suggested patch are:
- I don't know if it actually fixes the original problem.
- It can cause *more* redisplay work because it will force redisplay of
  all the windows in the current frame (rather than only their mode
  lines).

> I'm not against experimenting with replacing 42 by 32 or by
> REDISPLAY_SOME etc., but I don't think we should install anything
> along these lines, except if we need to fix a clear bug (i.e. a
> redisplay glitch), which this one isn't.

I don't know what you mean by "along these lines".


        Stefan






  reply	other threads:[~2020-12-17 19:45 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 15:36 bug#42406: Mouse-wheel scrolling can be flickering Konrad Podczeck
2020-07-19 13:33 ` Alan Third
2020-07-19 20:29   ` Konrad Podczeck
2020-07-22 20:16     ` Alan Third
2020-07-30 10:30       ` Konrad Podczeck
2020-08-01 13:12         ` Alan Third
2020-10-10  9:51         ` Alan Third
2020-10-10 14:07           ` Konrad Podczeck
2020-12-10 17:14             ` Konrad Podczeck
2020-12-10 22:10               ` Alan Third
2020-12-11  8:18                 ` Eli Zaretskii
2020-12-11 20:37                   ` Alan Third
2020-12-13 19:05                     ` Eli Zaretskii
2020-12-13 19:46                       ` Alan Third
2020-12-14  0:20                         ` Konrad Podczeck
2020-12-14 15:47                           ` martin rudalics
2020-12-14 20:46                             ` Konrad Podczeck
2020-12-15  7:58                               ` martin rudalics
2020-12-15 13:27                                 ` Konrad Podczeck
2020-12-15 13:51                                   ` martin rudalics
2020-12-15 14:06                                     ` Konrad Podczeck
2020-12-15 15:20                                       ` martin rudalics
2020-12-15 19:31                                         ` Konrad Podczeck
2020-12-15 19:45                                           ` Eli Zaretskii
2020-12-15 19:52                                             ` Konrad Podczeck
2020-12-15 20:05                                               ` Eli Zaretskii
2020-12-15 20:12                                                 ` Konrad Podczeck
2020-12-15 20:32                                                   ` Eli Zaretskii
2020-12-16  8:46                                                 ` martin rudalics
2020-12-16 15:58                                                   ` Eli Zaretskii
2020-12-16  8:46                                           ` martin rudalics
2020-12-16 16:00                                             ` Eli Zaretskii
2020-12-16 16:53                                               ` martin rudalics
2020-12-16 17:18                                                 ` Eli Zaretskii
2020-12-16 18:51                                                   ` martin rudalics
2020-12-16 19:35                                                     ` Eli Zaretskii
2020-12-17  7:29                                                       ` martin rudalics
2020-12-16 20:29                                                     ` Konrad Podczeck
2020-12-17  7:29                                                       ` martin rudalics
2020-12-17 10:19                                                         ` Konrad Podczeck
2020-12-17 13:21                                                           ` martin rudalics
2020-12-17 14:44                                                             ` Eli Zaretskii
2020-12-17 15:13                                                               ` martin rudalics
2020-12-17 16:54                                                                 ` Eli Zaretskii
2020-12-17 17:34                                                                   ` martin rudalics
2020-12-17 18:01                                                                     ` Eli Zaretskii
2020-12-17 23:19                                                                       ` martin rudalics
2020-12-18  7:50                                                                         ` Eli Zaretskii
2020-12-18  8:39                                                                           ` martin rudalics
2020-12-18 11:45                                                                             ` Eli Zaretskii
2020-12-18 13:57                                                                               ` martin rudalics
2020-12-19 10:04                                                                                 ` Eli Zaretskii
2020-12-17 16:40                                                             ` Konrad Podczeck
2020-12-17 17:05                                                               ` martin rudalics
2020-12-17 17:24                                                               ` Eli Zaretskii
2020-12-17 14:04                                                         ` Eli Zaretskii
2020-12-17 15:13                                                           ` martin rudalics
2020-12-17 16:49                                                             ` Eli Zaretskii
2020-12-17 17:34                                                               ` martin rudalics
2020-12-16 21:31                                       ` Alan Third
2020-12-16 23:53                                         ` Konrad Podczeck
2020-12-15 16:52                                 ` Eli Zaretskii
2020-12-15 17:14                                   ` martin rudalics
2020-12-15 18:35                                     ` Eli Zaretskii
2020-12-14 16:17                           ` Eli Zaretskii
2020-12-14 20:48                             ` Konrad Podczeck
2020-12-14 21:01                               ` Eli Zaretskii
2020-12-14 16:12                         ` Eli Zaretskii
2020-12-14 20:25                           ` Alan Third
2020-12-14 20:54                             ` Eli Zaretskii
2020-12-14 21:14                               ` Alan Third
2020-12-15  7:59                               ` martin rudalics
2020-12-15 17:38                                 ` Alan Third
2020-12-15 18:54                                   ` martin rudalics
2020-12-15 19:50                                     ` Alan Third
2020-12-16  8:46                                       ` martin rudalics
2020-12-16 21:35                                         ` Alan Third
2020-12-17 17:47                           ` Stefan Monnier
2020-12-17 18:16                             ` Eli Zaretskii
2020-12-17 19:45                               ` Stefan Monnier [this message]
2020-12-17 20:36                                 ` Eli Zaretskii
2020-12-17 21:07                                   ` Stefan Monnier
2020-12-18  7:43                                     ` Eli Zaretskii
2020-12-18 16:22                                       ` Stefan Monnier
2020-12-18 20:42                                         ` Eli Zaretskii
2020-12-18 23:12                                           ` Stefan Monnier
2020-12-19  7:44                                             ` Eli Zaretskii
2020-12-17 19:56                               ` Stefan Monnier
2020-12-17 20:35                                 ` Stefan Monnier
2020-12-17 20:58                                   ` Eli Zaretskii
2020-12-17 21:24                                     ` Stefan Monnier
2020-12-18  7:46                                       ` Eli Zaretskii
2020-12-18 14:41                                         ` Stefan Monnier
2020-12-17 20:47                                 ` Eli Zaretskii
2020-12-17 23:19                             ` martin rudalics
2020-12-17 23:24                               ` Stefan Monnier
2020-12-17 23:29                               ` Stefan Monnier
2020-12-18  7:56                                 ` martin rudalics
2021-05-21 10:23 ` bug#42406: macOS metal rendering engine in mac port Konrad Podczeck
2021-05-21 15:33   ` Aaron Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva6ucw7pq.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=42406@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=konrad.podczeck@univie.ac.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).