From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51173: 28.0.60; gnus-article-describe-key doesn't work Date: Fri, 15 Oct 2021 14:32:56 -0400 Message-ID: References: <87h7dl6spg.fsf@gnus.org> <87r1cox4th.fsf@mail.linkov.net> <87h7dkx2g5.fsf@mail.linkov.net> <87r1cm3hqb.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22852"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Katsumi Yamaoka , 51173@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 15 20:38:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbS5q-0005gi-N5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Oct 2021 20:38:11 +0200 Original-Received: from localhost ([::1]:57942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbS5p-0000yR-Gi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Oct 2021 14:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbS1r-0003CN-Lw for bug-gnu-emacs@gnu.org; Fri, 15 Oct 2021 14:34:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbS1r-00019Z-AF for bug-gnu-emacs@gnu.org; Fri, 15 Oct 2021 14:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mbS1r-0008Fb-5q; Fri, 15 Oct 2021 14:34:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 15 Oct 2021 18:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51173 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 51173-submit@debbugs.gnu.org id=B51173.163432279131607 (code B ref 51173); Fri, 15 Oct 2021 18:34:03 +0000 Original-Received: (at 51173) by debbugs.gnu.org; 15 Oct 2021 18:33:11 +0000 Original-Received: from localhost ([127.0.0.1]:40388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbS10-0008Dj-P8 for submit@debbugs.gnu.org; Fri, 15 Oct 2021 14:33:10 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbS0w-0008DC-Fo for 51173@debbugs.gnu.org; Fri, 15 Oct 2021 14:33:09 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 55B66440C27; Fri, 15 Oct 2021 14:33:00 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5178B440C16; Fri, 15 Oct 2021 14:32:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634322778; bh=I/AjK3WCbSrcscDnHN4eW7axzrZYiUzciXkQc6rNy0c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Anc8T9y+P67msHm5yo0J10BvNen/zgqECxJn/sjsY2W/rGfA6UeouslaXiZxfAYMi 0nDYSywVrmjvUu2WSBQG0NjEVWDNdEom3UtkBUTR3KQjeq31/5/BH7KibyvBRjcvZm +ZGnBUwliEPrjet+9/pxMstvwVkqWzAKAcweUR+yiwODivTs45o9nxJvpcN5KRfhXn gEyGH78Ha4Q0etcOYC9SMBMprfBUrkIUjtMHmVVA1AJ8AjBfnHo/u9QsWgWt9I7Jna pJVZ1xGAI+cDAuslHPPL8RbYID6UCFLs1wWF94tFU0RNovZ+hIix0chxhnY0byzSFO /bLfa/LTXxBGA== Original-Received: from ceviche (modemcable004.216-203-24.mc.videotron.ca [24.203.216.4]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DEA61120445; Fri, 15 Oct 2021 14:32:57 -0400 (EDT) In-Reply-To: <87r1cm3hqb.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 15 Oct 2021 09:49:32 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217323 Archived-At: > + (let* ((key (read-key-sequence nil t)) > + (buffer (if (consp key) > + (window-buffer (posn-window (event-start key))) > + (current-buffer)))) > + (describe-key key buffer)))) > + (describe-key key (if (consp key) > + (window-buffer (posn-window (event-start key))) > + (current-buffer))))) I think the first `describe-key` above should always use `current-buffer` (that's the whole point of the function: to lookup the keybinding in that other buffer). And for the second, it's supposed to be a fallback that does whatever `describe-key` does normally, so I don't see why we'd need/want this (if ...) construction. OTOH we should probably try and change the `key` arg to use the new key-list format expected by `describe-key` (i.e. a list of (SEQ . RAW-SEQ) pairs). > + (let ((key (read-key-sequence nil t)) > + (buffer (if (consp key) > + (window-buffer (posn-window (event-start key))) > + (current-buffer)))) > + (describe-key-briefly key insert buffer)))) > + (describe-key-briefly key insert > + (if (consp key) > + (window-buffer (posn-window (event-start key))) > + (current-buffer))))) Same here. Stefan