From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 51368@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#51368: 29.0.50; `cl-case' should error on incorrect use
Date: Sun, 14 Nov 2021 10:08:51 -0500 [thread overview]
Message-ID: <jwva6i6wzt4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAArVCkTWOGoZ_HmD6a7-n_+4xtgMqq-4zOK=19H4FLVThaou+g@mail.gmail.com> (Philipp Stephani's message of "Fri, 12 Nov 2021 20:34:13 +0100")
> Ok, I've attached two patches that implement these suggestions.
BTW, there's a third issue which is that
(cl-case EXP
((a b) FOO)
((a c) BAR))
won't warn about the duplicate `a`.
After fixing this, many/most uses of `quote` will already emit
a warning, so maybe it would make the quote/function part of your second
patch unnecessary.
Personally, I just recommend the use of `pcase` over `cl-case` ;-)
BTW, I just noticed the use of the `suspicious` category of
warning messages. Doesn't this category apply to all warnings?
Oh, and for the `nil` case and the presence of branches after
`otherwise`, the warnings could use the same text saying the branch
is unreachable.
Stefan
next prev parent reply other threads:[~2021-11-14 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 7:52 bug#51368: 29.0.50; `cl-case' should error on incorrect use Philipp Stephani
2021-10-24 8:16 ` Andreas Schwab
2021-10-24 12:46 ` Stefan Kangas
2021-10-24 17:48 ` Lars Ingebrigtsen
2021-10-31 18:53 ` Philipp Stephani
2021-11-01 13:31 ` Lars Ingebrigtsen
2021-11-12 19:34 ` Philipp Stephani
2021-11-14 1:09 ` Lars Ingebrigtsen
2021-11-14 15:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-09-13 15:19 ` Lars Ingebrigtsen
2022-09-13 16:12 ` Lars Ingebrigtsen
2022-09-13 16:15 ` Lars Ingebrigtsen
2023-09-03 8:48 ` Stefan Kangas
2022-10-02 21:39 ` Göktuğ Kayaalp
2023-09-03 13:40 ` Mattias Engdegård
2023-10-01 17:03 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva6i6wzt4.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=51368@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).