From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#9923: 24.0.91; `where-is' does not find recentf menu items (cmds, not files) Date: Mon, 06 Dec 2021 14:01:45 -0500 Message-ID: References: <76FA3F83D086455EAA01FF0FB000FCDB@us.oracle.com> <871r6hk99k.fsf@gnus.org> <87bl5k2ug1.fsf@gnus.org> <87czpwb4gw.fsf@mail.linkov.net> <8635n753o3.fsf@mail.linkov.net> <8635n613xt.fsf@mail.linkov.net> <86fsr5zlwg.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38899"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 9923@debbugs.gnu.org, Lars Ingebrigtsen To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 06 20:03:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1muJGr-0009uX-Aq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 20:03:29 +0100 Original-Received: from localhost ([::1]:56400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muJGq-0004Tx-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 14:03:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muJGQ-00048A-4T for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 14:03:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52120) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muJGP-00077c-To for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 14:03:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1muJGP-0003n5-Qg for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 14:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 9923-submit@debbugs.gnu.org id=B9923.163881732214468 (code B ref 9923); Mon, 06 Dec 2021 19:03:01 +0000 Original-Received: (at 9923) by debbugs.gnu.org; 6 Dec 2021 19:02:02 +0000 Original-Received: from localhost ([127.0.0.1]:35430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muJFS-0003lG-4t for submit@debbugs.gnu.org; Mon, 06 Dec 2021 14:02:02 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muJFP-0003kv-AP for 9923@debbugs.gnu.org; Mon, 06 Dec 2021 14:02:00 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E4504805B1; Mon, 6 Dec 2021 14:01:52 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 49E59801B5; Mon, 6 Dec 2021 14:01:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1638817311; bh=Att3YvZqvUuKJ96ULozO8Xu28edm09XLHsP2GixVOe0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AkMV+/0eV0eV98GLYsOaoV0R2bHOubC5KPAF6xGMeQ/XNl3Lx/NGZh7x+PUbfXpfu LU7zO3tMy2JoEFPi+tnO1t7fIU5JuES91XDFQK1e8MwSOQ9tzQztYhazxkA14nreEe H58qP1cHrsJdoBNiGziqLv+yJwQBji+7HlcJ+SXpGWYsSvQAKHttgcUCLqzP9exKYc 1H4aNITXd9sJ1nmZ90JzTxOyjo+THY0kU9PL7gUQRpoxRAx+ibmd0R6grZu1HFN2j2 73UhqMQ6tJAPkbFOxThOkZOHQ17cYQDfyA21IU2hbyHv6gHQLcxCWHO26sRTrR25p3 vmX1dY6Kqfn4w== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 298101206B6; Mon, 6 Dec 2021 14:01:51 -0500 (EST) In-Reply-To: <86fsr5zlwg.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 06 Dec 2021 19:24:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221782 Archived-At: > I confirm that it prevents `where-is-internal` from calling `context-menu-map`, > and everything else works fine, but I'm not sure how this change fits > into the overall design of the menu bindings. Maybe, `make-sparse-keymap` > means that `context-menu-entry` contains an empty menu initially. No, it's just that `where-is-internal` by-and-large doesn't run the `:filter`s when doing its search, so instead of seeing a binding to `ignore` it will see a binding to an empty keymap. As we've seen `where-is-internal` does end up running the `:filter` sometimes, but it's only done on those few bindings that match. When building a menu, the `ignore` or the empty keymap won't be used at all (their only use will be to pass them to the `:filter` function, which ignores that argument). That's why the "binding" is currently called `ignore`: not because we want to use the `ignore` command but as a way to say "this is not used". Stefan