unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 55161-done@debbugs.gnu.org, dick <dick.r.chiang@gmail.com>,
	55149-done@debbugs.gnu.org
Subject: bug#55149: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux
Date: Thu, 28 Apr 2022 09:42:08 -0400	[thread overview]
Message-ID: <jwva6c5iaw0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a6c5pkvr.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Apr 2022 12:23:04 +0200")

Lars Ingebrigtsen [2022-04-28 12:23:04] wrote:
> dick <dick.r.chiang@gmail.com> writes:
>
>> -   (:after (apply cdr r) (apply car r))
>> +   (:after (prog1 (apply cdr r) (apply car r)))
>
> I guess this is the same as bug#55149, so I've merged the reports.
>
> Apparently, returning the value of the :after function is what's
> documented to happen (and is what the trunk does now), but it didn't
> use to do that, so it's breaking advice that relies on the old
> behaviour, if I understand 55149 correctly.
> Stefan?

Yes, I implemented the new code from the doc (since the old code was
written in the form of an "undecipherable" bytecode string), but the doc
was wrong.  It's now fixed.


        Stefan






  parent reply	other threads:[~2022-04-28 13:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  5:15 bug#55161: 29.0.50; [PATCH] oclosure transcription error redux dick
2022-04-28 10:23 ` bug#55149: " Lars Ingebrigtsen
2022-04-27 12:48   ` bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Tassilo Horn
2022-04-27 19:41     ` No Wayman
2022-04-27 21:48       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28  3:39         ` Tassilo Horn
2022-04-28  4:02           ` No Wayman
2022-04-28  6:58         ` Juri Linkov
2022-04-28  7:12           ` Tassilo Horn
2022-04-28  7:22             ` Juri Linkov
2022-04-28  7:31               ` Tassilo Horn
2022-04-28 13:39           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28 14:14             ` Tassilo Horn
2022-04-28 14:28               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28 14:39                 ` Tassilo Horn
2022-04-28  2:06     ` bug#55149: (No Subject) M. Ian Graham
2022-04-28  4:06     ` bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor M. Ian Graham
2022-04-28  4:47       ` Tassilo Horn
2022-04-28  6:12         ` M. Ian Graham
2022-04-28  6:28           ` Tassilo Horn
2022-04-28  6:56             ` M. Ian Graham
2022-04-28 13:50     ` bug#55149: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux Rudolf Schlatte
2022-04-28 13:28   ` dick
2022-04-28 13:42   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-04-28 15:26     ` bug#55161: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Jonas Bernoulli
2022-04-28 16:32       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28 22:49         ` Jonas Bernoulli
2022-04-28 23:44           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva6c5iaw0.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=55149-done@debbugs.gnu.org \
    --cc=55161-done@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).