From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame Date: Thu, 07 Jul 2022 14:57:02 -0400 Message-ID: References: <83h73w8f7i.fsf@gnu.org> <83zghn7ckd.fsf@gnu.org> <83zghm5evt.fsf@gnu.org> <878rp6qd9t.fsf@igel.home> <874jzuqcr7.fsf@igel.home> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5794"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: rudalics@gmx.at, Eli Zaretskii , Andreas Schwab , 56305@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 07 21:07:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9WqL-0001Ha-SK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 21:07:17 +0200 Original-Received: from localhost ([::1]:46470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9WqK-0007PA-KX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 15:07:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9WhP-0001TS-0a for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 14:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9WhO-0001y3-MX for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 14:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9WhO-0003k8-H3 for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 14:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2022 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56305 X-GNU-PR-Package: emacs Original-Received: via spool by 56305-submit@debbugs.gnu.org id=B56305.165722025014348 (code B ref 56305); Thu, 07 Jul 2022 18:58:02 +0000 Original-Received: (at 56305) by debbugs.gnu.org; 7 Jul 2022 18:57:30 +0000 Original-Received: from localhost ([127.0.0.1]:57968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Wgs-0003jM-FB for submit@debbugs.gnu.org; Thu, 07 Jul 2022 14:57:30 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Wgm-0003j5-O3 for 56305@debbugs.gnu.org; Thu, 07 Jul 2022 14:57:29 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 044B9100163; Thu, 7 Jul 2022 14:57:19 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B58D6100130; Thu, 7 Jul 2022 14:57:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1657220232; bh=2lZLyW9sOxhPr0SeE3/UC1pgmVVsnKSGHn96hnXdlPM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LzjNdwBzQDTi5R1CxWInTxmFpBACl6dB+Cz+HlgFNhnTQgNYnOfHAH1eREUtn5mQ2 osTK2rxdCOKYcLHTc1PEIpbEwdTbS9hxNW57hhw/KXisPHZt+50ENCHFb5iyrwmxXN xGX9jGM2LDsA+E5/L0oScw9DX8Ka7L8P6WG6hbxDV7t8LUxnrPlGA+/ZjttmM9efKH QwvbWkvpomsq8uKk0Is+8MVHZokmLQK7g7ugGWx8cI9Xu4AyQW+pNzOGOIw4digrJn h2KofoUQEtsUrsGzwETOvlRndoqLh1VejBP+Al9KzWMM2DGqvywv7ai3KMhWofmawm +bgtQSKT5xQXQ== Original-Received: from alfajor (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5CCBE12055C; Thu, 7 Jul 2022 14:57:12 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Thu, 7 Jul 2022 17:25:31 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236414 Archived-At: > diff --git a/src/minibuf.c b/src/minibuf.c > index 0fc7f2caa1..71fd62cede 100644 > --- a/src/minibuf.c > +++ b/src/minibuf.c > @@ -896,6 +896,12 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, > /* Don't allow the user to undo past this point. */ > bset_undo_list (current_buffer, Qnil); > > + /* If some Emacs frame currently has the window-system focus, give > + it to the minibuffer frame. This is sometimes needed for > + minibuffer-only frames. */ > + if (FRAME_DISPLAY_INFO (XFRAME (mini_frame))->x_focus_frame) > + Fx_focus_frame (mini_frame, Qt); > + > recursive_edit_1 (); To avoid problems when we play with actual focus, what happens if we play with the focus-redirection here instead? Stefan