unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Matt Armstrong <matt@rfc20.org>, 58975@debbugs.gnu.org
Subject: bug#58975: 29.0.50; noverlay fails to build with --enable-checking=structs
Date: Wed, 02 Nov 2022 21:55:07 -0400	[thread overview]
Message-ID: <jwva658x0s6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <874jvg3n8z.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 03 Nov 2022 02:17:16 +0200")

> Is this the right fix?

The patch looks good, thanks.

> BTW, every time itree_create is called via add_buffer_overlay, it in
> turn calls itree_init,

Oh, that's not right.  `itree_init` should be called once only, from
`emacs.c`, like things like `init_lread`.

> which calls itree_iterator_create, which xmallocs a new
> itree_iterator, interval_stack, and itree_nodes.  Is this memory leak
> going to rust my computer?

No, Emacs is pure C and ELisp, so it doesn't suffer from Rust.


        Stefan






  reply	other threads:[~2022-11-03  1:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03  0:17 bug#58975: 29.0.50; noverlay fails to build with --enable-checking=structs Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-03  1:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-03 12:26   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-03 14:24     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-03 14:57       ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva658x0s6.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=58975@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=matt@rfc20.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).