From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#60974: 30.0.50; byte-compile-preprocess mutates self evaluating forms in expanded macro bodies Date: Tue, 31 Jan 2023 09:34:50 -0500 Message-ID: References: <6eb5f27bf591c3d52766d8b9da46e7301f2ff0ab.camel@gmail.com> <5ccd0d1f9f64a5fd20e5403a07b06d6074b6c8f6.camel@gmail.com> <2d72943db9995af6a98744f4a4da3cef98773b86.camel@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19873"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60974@debbugs.gnu.org, emacs-devel To: Vibhav Pant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 31 15:51:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMryk-0004sf-IM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Jan 2023 15:51:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMrk2-0006kv-VR; Tue, 31 Jan 2023 09:36:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMrjv-0006Zu-5a for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 09:36:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMrju-0001ze-Ti for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 09:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMrju-0000TY-In for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 09:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2023 14:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60974 X-GNU-PR-Package: emacs Original-Received: via spool by 60974-submit@debbugs.gnu.org id=B60974.16751757021713 (code B ref 60974); Tue, 31 Jan 2023 14:36:02 +0000 Original-Received: (at 60974) by debbugs.gnu.org; 31 Jan 2023 14:35:02 +0000 Original-Received: from localhost ([127.0.0.1]:51975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMriv-0000RW-HT for submit@debbugs.gnu.org; Tue, 31 Jan 2023 09:35:01 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMrit-0000RA-7S for 60974@debbugs.gnu.org; Tue, 31 Jan 2023 09:35:00 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 867881000C7; Tue, 31 Jan 2023 09:34:53 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F3A5710000D; Tue, 31 Jan 2023 09:34:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675175692; bh=uvEgDJH82J+KDtZi10u+uE0LkD8z5xXNaNejihftyIQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Oz9pRNIWfyOXBGlfxKKlz0IEVB43e67o+ksaumCo0c5VWNOzlDN+634UNFHsHvL6q IXrOPOUhmg/gJjJqF3IM15Ij2R+i65TrAU0ezQC4fihENrobRi+MgeM6nZ/l0WO7qG Jttr+18fL2RftYRupUC7sDaBJldWiI+ihjeDN/xy5/kjD8BOxVBSQ1/xY68+B1x7cB /F7GoUqgoCKSbwE37gIR1niRtD1XG8BAqA+m3LSSgfStdAf8W6JSI6nFn9DiqeaWAF qTkI7kb32DoO/IKZCRPli2BvGkqmDeLcJZuICESqqGi+q4/pbP+YPjjqsYaFUwjs63 NDDWyYNwk0GZg== Original-Received: from pastel (unknown [45.72.238.67]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AD3A6120CD8; Tue, 31 Jan 2023 09:34:51 -0500 (EST) In-Reply-To: <2d72943db9995af6a98744f4a4da3cef98773b86.camel@gmail.com> (Vibhav Pant's message of "Tue, 31 Jan 2023 19:22:56 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254520 gmane.emacs.devel:302827 Archived-At: >> > Ah, right. Theother way I could think of a fix is setq-ing `form` >> > to a >> > shallow copy of the original form, with only the place(s) changed. >> > This >> > patch tries to do that by using `pcase-let` to destructure forms. >>=20 >> Hmm... yes, that's closer.=A0 It's pretty ugly, tho. >> Yet it's hard to make it less ugly here because the >> `cconv-freevars-alist` really depends on `eq` equality. >>=20 >> Maybe we should pass `cif` to `cconv--convert-function` (or maybe >> even >> move most of that `cconv--interactive-form-funs`-handling to that >> function) and arrange for that function to do the >> "non-side-effecting-equivalent-of" (setf (cadr (car bf)) form)? >>=20 >>=20 >> =A0=A0=A0=A0=A0=A0=A0 Stefan >>=20 > > I tried to shift the `cif` related bits to `cconc--convert-function`, > but my understanding of cconv.el isn't that great, so I wasn't > successful at doing that :( Should I add a TODO to the change for the > future? Yes, please, Stefan