From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65491: [PATCH] Improve performance allocating vectors Date: Mon, 28 Aug 2023 08:47:45 -0400 Message-ID: References: <87y1i0iwvu.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4706"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65491@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 28 14:48:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qabfF-0000yG-KF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Aug 2023 14:48:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qabf5-0004ca-MZ; Mon, 28 Aug 2023 08:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qabet-0004cC-NK for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 08:47:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qabet-0003ky-EX for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 08:47:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qabez-00047j-OE for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 08:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 12:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65491-submit@debbugs.gnu.org id=B65491.169322688115845 (code B ref 65491); Mon, 28 Aug 2023 12:48:01 +0000 Original-Received: (at 65491) by debbugs.gnu.org; 28 Aug 2023 12:48:01 +0000 Original-Received: from localhost ([127.0.0.1]:47352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qabey-00047Q-PH for submit@debbugs.gnu.org; Mon, 28 Aug 2023 08:48:01 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qabex-00046k-E8 for 65491@debbugs.gnu.org; Mon, 28 Aug 2023 08:47:59 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A470E8072D; Mon, 28 Aug 2023 08:47:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1693226866; bh=7lZXsAQpuS2suHoS5Mykn2KlWpGzjbfo8WHyzefBo1Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Kr9WU9q5dof6wMLXuX2zQq9BGTzl2QvNpX0/W7I5NWNZkuIZZBuGLCv5oEdMX83ak vOkZPlhV5xOODYtW/qzQDCrqtn2wRvNC4jMHZELeWXNnoIwZhQjtC8ryUlb2fkpTHA l4LzIpYvAqNPtlcd1pUgN22avfggU4ibcuh40FciEqhEHty70dA01/rl26bNAWflSG wF87iGC85mrEJw7EImYeuETaofl4dHijJY8rU8jdUQ0JkelwZyHjzFEdMmVlV3jKh1 H3xcYLmHwvi6/WzA1LCR6bs6fFLJMSpOabP9SgiCII39eRlHacpKTWC9OnCBoufzQp /E18pfVY0T+xw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8074080348; Mon, 28 Aug 2023 08:47:46 -0400 (EDT) Original-Received: from pastel (unknown [108.175.234.188]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 603C1120298; Mon, 28 Aug 2023 08:47:46 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 27 Aug 2023 12:21:30 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268623 Archived-At: >> @@ -3426,6 +3428,7 @@ sweep_vectors (void) >> gcstat.total_vectors = 0; >> gcstat.total_vector_slots = gcstat.total_free_vector_slots = 0; >> memset (vector_free_lists, 0, sizeof (vector_free_lists)); >> + last_known_vector_free_idx = VECTOR_MAX_FREE_LIST_INDEX; >> >> /* Looking through vector blocks. */ > > Hmm... so I was wrong and after GC there are aren't any free vectors? > I need to go re-read that code, then, because it doesn't match my mental > model of how it work(s|ed). Ah, no, I see what's going on: the above code is run at the *beginning* of `sweep_vectors` before we discover which (free) vectors remain. Stefan