unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 1741@emacsbugs.donarmstrong.com, Dan Nicolaescu <dann@ics.uci.edu>
Subject: bug#1741: 23.0.60; vc fail to register file while logged as /su:: with tramp
Date: Sun, 12 Apr 2009 18:51:17 -0400	[thread overview]
Message-ID: <jwv8wm5xzqq.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87r5zxprx9.fsf@gmx.de> (Michael Albinus's message of "Sun, 12 Apr 2009 21:56:18 +0200")

>> process-file is something that it not used very often, so I think it's
>> perfectly OK to flush the whole host's cache at that point.  If it turns
>> out to be a performance problem, we can refine this choice.

> It depends on the use case. `find-grep-dired' is something I call
> permanently, for example.

Sure.  But think of how many Tramp operations take place between those
calls to process-file and what proportion of those operations will be
affected by the cache-flush:
- X% will not be affected because it wasn't in the cache.
- Y% will be affected.
- the remaining (100-X-Y)% won't be affected because it touches the same
  data as the previous Y%.
My guess is that Y is sufficiently low (e.g. compared to X) for it not
to be a problem.

> For a performance comparision, you could check the figures in
> <http://cvs.savannah.gnu.org/viewvc/*checkout*/tramp/test/tramp-time.el?root=tramp>.

> Tramp 2.0 has no cache, Tramp 2.1 does.  The figures are some years old,
> but they shall be still valid.

This only measures the effectiveness of caching on synthetic benchmarks.
I do not doubt that the cache is effective.  Flushing will obviously
have an effect on performance, but that doesn't mean that flushing the
cache during process-file will cause a performance problem.

AFAIK the main benefit of the cache is to bundle up all the redundant
`file-attibutes' calls that take place during something like
`find-file-noselect'.  Such optimizations won't be affected by the
cache-flush.  So I expect that the cache-flush I suggest won't cause
a performance problem.


        Stefan






  reply	other threads:[~2009-04-12 22:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200904150011.n3F0BT8Q005193@godzilla.ics.uci.edu>
2008-12-30 10:48 ` bug#1741: 23.0.60; vc fail to register file while logged as /su:: with tramp Thierry Volpiatto
2009-04-07 16:57   ` Dan Nicolaescu
2009-04-08 11:23     ` thierry.volpiatto
2009-04-08 16:24       ` Dan Nicolaescu
2009-04-08 17:53         ` Stefan Monnier
2009-04-09 13:51           ` Michael Albinus
2009-04-09 14:38             ` Stefan Monnier
2009-04-09 15:06               ` Michael Albinus
2009-04-09 18:23                 ` Stefan Monnier
2009-04-12 18:15                   ` Michael Albinus
2009-04-12 19:41                     ` Stefan Monnier
2009-04-12 19:56                       ` Michael Albinus
2009-04-12 22:51                         ` Stefan Monnier [this message]
2009-04-13  9:30                           ` Michael Albinus
2009-04-13 12:24                             ` Stefan Monnier
2009-04-14 15:19                               ` Michael Albinus
2009-04-14 17:06                                 ` Stefan Monnier
2009-04-15 20:55                                   ` Michael Albinus
2009-04-15  0:20   ` bug#1741: marked as done (23.0.60; vc fail to register file while logged as /su:: with tramp) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8wm5xzqq.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=1741@emacsbugs.donarmstrong.com \
    --cc=dann@ics.uci.edu \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).