From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3892: corrupting load-in-progress value with "let" Date: Thu, 23 Jul 2009 21:14:48 -0400 Message-ID: References: <47712C91-B427-4C1C-8731-F8BE9463A4A3@raeburn.org> <42A7787D-BA88-4613-BE99-F02C44904A1C@raeburn.org> Reply-To: Stefan Monnier , 3892@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1248399471 8666 80.91.229.12 (24 Jul 2009 01:37:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jul 2009 01:37:51 +0000 (UTC) Cc: 3892@emacsbugs.donarmstrong.com To: Ken Raeburn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 24 03:37:44 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MU9jB-0001ee-Rc for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Jul 2009 03:37:42 +0200 Original-Received: from localhost ([127.0.0.1]:39634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MU9jB-0008Cp-8r for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Jul 2009 21:37:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MU9j6-0008CZ-PX for bug-gnu-emacs@gnu.org; Thu, 23 Jul 2009 21:37:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MU9j2-0008CJ-Gk for bug-gnu-emacs@gnu.org; Thu, 23 Jul 2009 21:37:36 -0400 Original-Received: from [199.232.76.173] (port=35049 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MU9j2-0008C9-Do for bug-gnu-emacs@gnu.org; Thu, 23 Jul 2009 21:37:32 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41838) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MU9j1-0003wK-V5 for bug-gnu-emacs@gnu.org; Thu, 23 Jul 2009 21:37:32 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6O1bUuw008339; Thu, 23 Jul 2009 18:37:30 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n6O1K4nc005513; Thu, 23 Jul 2009 18:20:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 24 Jul 2009 01:20:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3892 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3892-submit@emacsbugs.donarmstrong.com id=B3892.12483980994673 (code B ref 3892); Fri, 24 Jul 2009 01:20:04 +0000 Original-Received: (at 3892) by emacsbugs.donarmstrong.com; 24 Jul 2009 01:14:59 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6O1Et9R004657 for <3892@emacsbugs.donarmstrong.com>; Thu, 23 Jul 2009 18:14:56 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApIFAC+oaEpFpZx3/2dsb2JhbACBUc84hA0Fhws X-IronPort-AV: E=Sophos;i="4.43,259,1246852800"; d="scan'208";a="42084367" Original-Received: from 69-165-156-119.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.119]) by ironport2-out.teksavvy.com with ESMTP; 23 Jul 2009 21:14:48 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id EEC8C84A3; Thu, 23 Jul 2009 21:14:48 -0400 (EDT) In-Reply-To: <42A7787D-BA88-4613-BE99-F02C44904A1C@raeburn.org> (Ken Raeburn's message of "Thu, 23 Jul 2009 20:08:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 23 Jul 2009 21:37:36 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29600 Archived-At: >>> I think we should drop the counter altogether, and use specbind instead. >> Much simpler, yes, and it looks like nothing in the C code cares about the >> numeric value either. >> Thanks for the suggestion; I'll revise my patch. > I'm working on the revised patch, but it occurs to me that this way, some > broken bit of code could set load-in-progress to t at some point when > nothing is being loaded, and it will never become nil again unless > explicitly reset. Isn't that a problem that already exists? In any case such setting would be a bug, so I wouldn't worry about it. > A related issue: If we're changing the way it's set, should we retain the > constraint that load-in-progress can only (appear to) hold boolean values, > or let it hold any Lisp value instead? A boolean seems sufficient, I see no need to change it for now, Stefan