From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6399: Confirm vc commits when the files do not match those marked in vc-dir Date: Fri, 11 Jun 2010 01:53:56 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1276235944 18468 80.91.229.12 (11 Jun 2010 05:59:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 11 Jun 2010 05:59:04 +0000 (UTC) Cc: 6399@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 11 07:59:01 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OMxGe-00062r-M3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Jun 2010 07:59:00 +0200 Original-Received: from localhost ([127.0.0.1]:52532 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMxGe-00031E-6U for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Jun 2010 01:59:00 -0400 Original-Received: from [140.186.70.92] (port=59446 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMxFy-0002hp-DD for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 01:58:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMxFx-0006lc-0P for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 01:58:18 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50466) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMxFw-0006lY-VI for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 01:58:16 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OMxCo-0003MQ-10; Fri, 11 Jun 2010 01:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jun 2010 05:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6399-submit@debbugs.gnu.org id=B6399.127623564212892 (code B ref 6399); Fri, 11 Jun 2010 05:55:01 +0000 Original-Received: (at 6399) by debbugs.gnu.org; 11 Jun 2010 05:54:02 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMxBp-0003Lt-Ti for submit@debbugs.gnu.org; Fri, 11 Jun 2010 01:54:02 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMxBo-0003Lh-S0 for 6399@debbugs.gnu.org; Fri, 11 Jun 2010 01:54:01 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAN5rEUxMCqeQ/2dsb2JhbACeeHK9XYUYBIx6 X-IronPort-AV: E=Sophos;i="4.53,402,1272859200"; d="scan'208";a="67822084" Original-Received: from 76-10-167-144.dsl.teksavvy.com (HELO alfajor.home) ([76.10.167.144]) by ironport2-out.pppoe.ca with ESMTP; 11 Jun 2010 01:53:56 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id 41128AE008; Fri, 11 Jun 2010 01:53:56 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Thu, 10 Jun 2010 23:50:24 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 11 Jun 2010 01:55:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37691 Archived-At: > I've made this mistake a few times now: > 1) Mark say 5 files in vc-dir. > 2) Press v to get a vc-log buffer. > 3) Realize I should not have marked one of the 5 files, and unmark it > in the vc-dir buffer. > 4) Forget to kill the existing vc-log buffer, and so end up committing > all 5 files anyway. > I wish that at step 4 when I try to commit, Emacs would check if the > files about to be commited match those marked in the vc-dir buffer, > and if not ask me to confirm the commit. Agreed. That's what PCL-CVS does. PCL-CVS goes one step further, actually: if there's a discrepancy (and the user confirms that the discrepancy is OK), it's the *cvs* (aka *vc-dir*) selection that takes precedence over the list of files that was active when the vc-log buffer was created. Stefan