From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6490: 24.0.50; src/lread.c: old style backquote bug? Date: Wed, 23 Jun 2010 00:23:15 +0200 Message-ID: References: <86iq5bifzr.wl%%cc9230e4f6b11649d75e8c3813911dbe1dd37419@be.to> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1277245749 3165 80.91.229.12 (22 Jun 2010 22:29:09 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 22 Jun 2010 22:29:09 +0000 (UTC) Cc: 6490@debbugs.gnu.org To: Tetsurou Okazaki Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 23 00:29:06 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ORBxq-0003dN-7Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jun 2010 00:29:06 +0200 Original-Received: from localhost ([127.0.0.1]:42345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ORBxp-00067k-NR for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Jun 2010 18:29:05 -0400 Original-Received: from [140.186.70.92] (port=46176 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ORBxk-00065T-30 for bug-gnu-emacs@gnu.org; Tue, 22 Jun 2010 18:29:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ORBxj-0007jp-27 for bug-gnu-emacs@gnu.org; Tue, 22 Jun 2010 18:28:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41724) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORBxi-0007jh-VQ for bug-gnu-emacs@gnu.org; Tue, 22 Jun 2010 18:28:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1ORBsv-0003KO-KL; Tue, 22 Jun 2010 18:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2010 22:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6490-submit@debbugs.gnu.org id=B6490.127724540212784 (code B ref 6490); Tue, 22 Jun 2010 22:24:01 +0000 Original-Received: (at 6490) by debbugs.gnu.org; 22 Jun 2010 22:23:22 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORBsI-0003K9-7t for submit@debbugs.gnu.org; Tue, 22 Jun 2010 18:23:22 -0400 Original-Received: from smtp-02.vtx.ch ([194.38.175.91]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORBsG-0003K4-6Z for 6490@debbugs.gnu.org; Tue, 22 Jun 2010 18:23:21 -0400 Original-Received: from ceviche.home (dyn.83-228-208-093.dsl.vtx.ch [83.228.208.93]) by smtp-02.vtx.ch (VTX Services SA) with ESMTP id 3E9765FCEB; Wed, 23 Jun 2010 00:23:15 +0200 (CEST) Original-Received: by ceviche.home (Postfix, from userid 20848) id 5945766130; Wed, 23 Jun 2010 00:23:15 +0200 (CEST) In-Reply-To: <86iq5bifzr.wl%%cc9230e4f6b11649d75e8c3813911dbe1dd37419@be.to> (Tetsurou Okazaki's message of "Tue, 22 Jun 2010 18:16:56 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 22 Jun 2010 18:24:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37956 Archived-At: > Attached patch for Emacs fixes this error. I'm glad the patch fixes things for you, since this patch indeed looks perfectly harmless, but I'm a bit puzzled because it doesn't just look harmless: it looks to me like the patch does change anything to the way the code works. So could you explain to me how&why the patch fixes the problem? I'm probably just overlooking some "obvious" detail, Stefan > === modified file 'src/lread.c' > --- src/lread.c 2010-06-16 14:10:02 +0000 > +++ src/lread.c 2010-06-22 07:48:58 +0000 > @@ -2693,21 +2693,26 @@ > old-style. For Emacs-25, we should completely remove this > first_in_list exception (old-style can still be obtained via > "(\`" anyway). */ > - if (first_in_list && (c = READCHAR, UNREAD (c), c == ' ')) > - { > - Vold_style_backquotes = Qt; > - goto default_label; > - } > - else > - { > - Lisp_Object value; > - > - new_backquote_flag++; > - value = read0 (readcharfun); > - new_backquote_flag--; > - > - return Fcons (Qbackquote, Fcons (value, Qnil)); > - } > + { > + int next_char = READCHAR; > + UNREAD (next_char); > + > + if (first_in_list && next_char == ' ') > + { > + Vold_style_backquotes = Qt; > + goto default_label; > + } > + else > + { > + Lisp_Object value; > + > + new_backquote_flag++; > + value = read0 (readcharfun); > + new_backquote_flag--; > + > + return Fcons (Qbackquote, Fcons (value, Qnil)); > + } > + } > case ',': > if (new_backquote_flag)