unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: jidanni@jidanni.org
Cc: 10116@debbugs.gnu.org
Subject: bug#10116: M-x compile no longer completes filenames
Date: Tue, 06 Dec 2011 17:16:46 -0500	[thread overview]
Message-ID: <jwv8vmpcpsf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878vn7wpyu.fsf@jidanni.org> (jidanni@jidanni.org's message of "Wed, 23 Nov 2011 10:08:09 +0800")

> As of emacs-snapshot:
>   Installed: 1:20111121-1
> M-x compile
> make -k <TAB>
> no longer completes filenames.

Indeed, the completion rules for `make' failed to mention that file
names are perfectly valid arguments.  I've just installed the patch
below which should address this problem.

> Furthermore, more TABs will get you
> Error in post-command-hook (completion-in-region--postch): (error IO error
> reading /var/tmp: Is a directory)
> insert-file-contents-literally: IO error reading /var/tmp: Is a directory

I can't reproduce this problem.  Can you give more detailed steps to
reproduce it?


        Stefan


=== modified file 'lisp/pcmpl-gnu.el'
--- lisp/pcmpl-gnu.el	2011-12-02 14:44:19 +0000
+++ lisp/pcmpl-gnu.el	2011-12-06 22:11:15 +0000
@@ -99,7 +99,10 @@
   "Completion for GNU `make'."
   (let ((pcomplete-help "(make)Top"))
     (pcomplete-opt "bmC/def(pcmpl-gnu-makefile-names)hiI/j?kl?no.pqrsStvwW.")
-    (while (pcomplete-here (pcmpl-gnu-make-rule-names) nil 'identity))))
+    (while (pcomplete-here (completion-table-in-turn
+                            (pcmpl-gnu-make-rule-names)
+                            (pcomplete-entries))
+                           nil 'identity))))
 
 (defun pcmpl-gnu-makefile-names ()
   "Return a list of possible makefile names."






  reply	other threads:[~2011-12-06 22:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23  2:08 bug#10116: M-x compile no longer completes filenames jidanni
2011-12-06 22:16 ` Stefan Monnier [this message]
2011-12-07  0:22 ` jidanni
2011-12-07  1:29   ` Stefan Monnier
2011-12-08 13:20   ` Stefan Monnier
2011-12-07  1:40 ` jidanni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8vmpcpsf.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=10116@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).