From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#2224: [PATCH] add-log.el: Modularize add-log-current-defun, new types supported Date: Thu, 12 Apr 2012 16:38:57 -0400 Message-ID: References: <87bptf5upl.fsf@jondo.cante.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1334263199 5274 80.91.229.3 (12 Apr 2012 20:39:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 12 Apr 2012 20:39:59 +0000 (UTC) Cc: 2224@debbugs.gnu.org, Jari Aalto To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 12 22:39:57 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SIQo6-00007J-9L for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2012 22:39:54 +0200 Original-Received: from localhost ([::1]:51319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIQo5-0001up-Fg for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2012 16:39:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIQo2-0001uE-De for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 16:39:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SIQo0-0002bU-Cu for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 16:39:49 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIQo0-0002aA-9F for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 16:39:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SIQpB-0004zI-Rt for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 16:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2012 20:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 2224-submit@debbugs.gnu.org id=B2224.133426322219109 (code B ref 2224); Thu, 12 Apr 2012 20:41:01 +0000 Original-Received: (at 2224) by debbugs.gnu.org; 12 Apr 2012 20:40:22 +0000 Original-Received: from localhost ([127.0.0.1]:54930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIQoV-0004y8-Qp for submit@debbugs.gnu.org; Thu, 12 Apr 2012 16:40:21 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:36506) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIQoP-0004xv-7k for 2224@debbugs.gnu.org; Thu, 12 Apr 2012 16:40:13 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q3CKcvlJ025966; Thu, 12 Apr 2012 16:38:57 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 9D5F8B4066; Thu, 12 Apr 2012 16:38:57 -0400 (EDT) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Thu, 12 Apr 2012 20:19:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4190=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4190> : streams <746336> : uri <1098517> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58945 Archived-At: >> Think about it: why should add-log support be different than say, >> font-lock, outline, imenu, younameit? Oh and BTW, this same function >> can/should be used for which-func-mode. > --- > Which Function mode is a global minor mode. When enabled, the > current function name is continuously displayed in the mode line, > in certain major modes. > --- > Didn't know about that one. Seems useful, especially if you're hacking > on stuff that uses looong functions. (I've been doing some minor hacks > on mplayer, and it has, if I recall correctly, a few functions that are > in the 1500 line region...) > Anyway, that obviously makes sense. :-) >> Of course in js.el it shouldn't be called >> `add-log-current-defun-type-javascript' but `js--current-defun-name' or >> something like that. > --? Isn't that for internal functions? These would be used by the > other packages... Using them is not a problem: using them directly is a problem. External packages such as add-log.el will just do (funcall add-log-current-defun-function) and won't care about the name of the function. But if you want to name it js-current-defun-name, that's fine as well, I don't have a strong preference between the two. Stefan