unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: michael_heerdegen@web.de
Cc: 11342-done@debbugs.gnu.org
Subject: bug#11342: 24.1.50; HOOK variable name in `add-hook' etc. confusing
Date: Tue, 15 May 2012 10:46:54 -0400	[thread overview]
Message-ID: <jwv8vgtqzfh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y5pjjurd.fsf@web.de>

>   remove-hook: (HOOK FUNCTION &optional LOCAL)
> You could misinterpret that and think that the first argument must be
> a value representing a hook.  But actually it must be a _symbol_
> holding a hook.

Actually, the docstring says "HOOK should be a symbol", so the problem
is only that you base your decision on the eldoc info, which is
necessarily too limited to be trusted to give that kind of detail.

I find that changing the argument name makes the code and docstring too
verbose for my taste, so I don't think it's worth the trouble.


        Stefan





      parent reply	other threads:[~2012-05-15 14:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 22:45 bug#11342: 24.1.50; HOOK variable name in `add-hook' etc. confusing Michael Heerdegen
2012-04-26  1:15 ` Stefan Monnier
2012-04-26  2:07   ` Michael Heerdegen
2012-04-26  8:03     ` Andreas Schwab
2012-04-26 12:47       ` Stefan Monnier
2012-04-26 21:31       ` Michael Heerdegen
2012-05-15 14:46 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8vgtqzfh.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=11342-done@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).