unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: rms@gnu.org
Cc: 13023@debbugs.gnu.org
Subject: bug#13023: 24.3.50; lexical binding does not work within defadvice
Date: Fri, 30 Nov 2012 23:23:18 -0500	[thread overview]
Message-ID: <jwv8v9iz9k5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1TeWvb-0006lO-Uz@fencepost.gnu.org> (Richard Stallman's message of "Fri, 30 Nov 2012 15:11:15 -0500")

> Is there something wrong with defadvice?

Yes: complexity.  Compare nadvice.el and advice.el.  Even after you
remove the long comment at the beginning, the difference in code size
speaks for itself.


        Stefan





  reply	other threads:[~2012-12-01  4:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 16:17 bug#13023: 24.3.50; lexical binding does not work within defadvice Christopher Schmidt
2012-11-29  4:32 ` Stefan Monnier
2012-11-29 22:50   ` Richard Stallman
2012-11-30  3:45     ` Stefan Monnier
2012-11-30 20:11       ` Richard Stallman
2012-12-01  4:23         ` Stefan Monnier [this message]
2012-12-02  0:00           ` Juanma Barranquero
2012-12-02  4:15           ` Richard Stallman
2012-12-03  0:01             ` Richard Stallman
2016-02-02 18:35 ` Marcin Borkowski
2016-02-02 19:42   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8v9iz9k5.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=13023@debbugs.gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).