From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Leo Liu <sdl.web@gmail.com>
Cc: 14395@debbugs.gnu.org
Subject: bug#14395: 24.3; [PATCH] new feature smie-highlight-matching-block
Date: Tue, 14 May 2013 12:02:38 -0400 [thread overview]
Message-ID: <jwv8v3hmuds.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m138tq46of.fsf@gmail.com> (Leo Liu's message of "Tue, 14 May 2013 10:49:20 +0800")
> I want something for octave mode that looks like something in the
> attached screenshot. But since this is generic I would like to put it in
> smie.el. Do you have any objections or comments?
Looks like a good feature, thank you.
> It doesn't make sense for this feature and smie-blink-matching-open to
> be on at the same time. So in the patch nothing is enabled.
I don't think enabling it in octave-mode makes sense: this is more like
"blink-paren vs show-paren-mode", i.e. a personal preference. So the
enabling/disabling should be done via code in smie.el.
> + (when (and (bound-and-true-p smie-closer-alist)
It's defvarred to nil, so don't test if it's boundp.
> + (let ((open-re (concat "\\_<"
> + (regexp-opt (mapcar 'car smie-closer-alist))
> + "\\_>"))
> + (close-re (concat "\\_<"
> + (regexp-opt (mapcar 'cdr smie-closer-alist))
> + "\\_>"))
The string returned by smie-forward-token-function is usually the same
as the representation of the token in the buffer, but not always.
So the above is not strictly correct.
Instead you want to call smie-for/backward-token-function and then
compare the result via (r?assoc tok smie-closer-alist).
> + ((funcall beg-of-tok open-re)
> + (with-demoted-errors
> + (forward-sexp 1)
> + (when (looking-back close-re)
> + (funcall highlight (match-beginning 0) (match-end 0)))))
I think this should not use with-demoted-errors but instead should
explicitly catch the scan-error and turn it into a message.
After all, the user doesn't want to be thrown in the debugger just
because his sexp is not properly closed yet. And also this way you can
provide a much nicer error message.
Stefan
next prev parent reply other threads:[~2013-05-14 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 2:49 bug#14395: 24.3; [PATCH] new feature smie-highlight-matching-block Leo Liu
2013-05-14 16:02 ` Stefan Monnier [this message]
2013-05-15 7:13 ` Leo Liu
2013-05-16 2:31 ` Stefan Monnier
2013-05-16 3:27 ` Leo Liu
2013-05-16 13:24 ` Stefan Monnier
2013-05-16 16:06 ` Leo Liu
2013-05-16 17:51 ` Stefan Monnier
2013-05-16 23:09 ` Leo Liu
2013-05-17 0:40 ` Stefan Monnier
2013-05-17 1:30 ` Leo Liu
2013-05-22 18:50 ` Stefan Monnier
2013-05-16 4:45 ` Glenn Morris
2013-05-16 5:33 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8v3hmuds.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14395@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).