* bug#17001: `documentation' fails with void-function help-split-fundoc, due to advice @ 2014-03-12 20:04 Glenn Morris 2014-03-12 20:44 ` Glenn Morris 0 siblings, 1 reply; 4+ messages in thread From: Glenn Morris @ 2014-03-12 20:04 UTC (permalink / raw) To: 17001 Package: emacs Version: 24.3.50 Current trunk on GNU/Linux. emacs -Q (documentation 'rename-buffer) -> void-function help-split-fundoc The error comes from advice--make-docstring. nadvice.el could autoload help-split-fundoc. Since nadvice.el is preloaded, that's equivalent to sticking an autoload cookie on help-split-fundoc. Which might be a good thing, since several files autoload it manually. Or advice--make-docstring could require help-fns. PS Presumably the lispref statement "Emacs's own source files should not put advice on functions in Emacs." no longer applies, since nadvice.el is preloaded and eg simple.el uses it. ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#17001: `documentation' fails with void-function help-split-fundoc, due to advice 2014-03-12 20:04 bug#17001: `documentation' fails with void-function help-split-fundoc, due to advice Glenn Morris @ 2014-03-12 20:44 ` Glenn Morris 2014-03-12 21:13 ` Glenn Morris 0 siblings, 1 reply; 4+ messages in thread From: Glenn Morris @ 2014-03-12 20:44 UTC (permalink / raw) To: 17001 Glenn Morris wrote: > emacs -Q > (documentation 'rename-buffer) > -> void-function help-split-fundoc PS I wondered why the byte-compiler does not warn about this. Seems bytecomp.el now requires help-fns in some cases. That seems like it could cause precisely this kind of problem. ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#17001: `documentation' fails with void-function help-split-fundoc, due to advice 2014-03-12 20:44 ` Glenn Morris @ 2014-03-12 21:13 ` Glenn Morris 2014-03-13 13:36 ` Stefan Monnier 0 siblings, 1 reply; 4+ messages in thread From: Glenn Morris @ 2014-03-12 21:13 UTC (permalink / raw) To: 17001 Glenn Morris wrote: >> emacs -Q >> (documentation 'rename-buffer) >> -> void-function help-split-fundoc > > PS I wondered why the byte-compiler does not warn about this. > Seems bytecomp.el now requires help-fns in some cases. > That seems like it could cause precisely this kind of problem. PPS I see some wise person added related comments to help-fns.el some time ago; e.g.: ;; FIXME: Move to subr.el? (defun help-function-arglist (def &optional preserve-names) (why not to help.el, which is preloaded?) ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#17001: `documentation' fails with void-function help-split-fundoc, due to advice 2014-03-12 21:13 ` Glenn Morris @ 2014-03-13 13:36 ` Stefan Monnier 0 siblings, 0 replies; 4+ messages in thread From: Stefan Monnier @ 2014-03-13 13:36 UTC (permalink / raw) To: Glenn Morris; +Cc: 17001 > ;; FIXME: Move to subr.el? > (defun help-function-arglist (def &optional preserve-names) > (why not to help.el, which is preloaded?) help.el sounds good, indeed. Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-13 13:36 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-03-12 20:04 bug#17001: `documentation' fails with void-function help-split-fundoc, due to advice Glenn Morris 2014-03-12 20:44 ` Glenn Morris 2014-03-12 21:13 ` Glenn Morris 2014-03-13 13:36 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).