From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement. Date: Sun, 15 Jun 2014 00:14:06 -0400 Message-ID: References: <83tx7mvqhn.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402805729 18743 80.91.229.3 (15 Jun 2014 04:15:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Jun 2014 04:15:29 +0000 (UTC) Cc: 17777@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 15 06:15:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ww1qk-0000qv-1L for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jun 2014 06:15:22 +0200 Original-Received: from localhost ([::1]:37549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ww1qj-0007P9-II for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jun 2014 00:15:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ww1qZ-0007P2-Qx for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2014 00:15:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ww1qS-0000ps-6S for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2014 00:15:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ww1qS-0000pc-3T for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2014 00:15:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ww1qR-0000TE-Jp for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2014 00:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Jun 2014 04:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17777-submit@debbugs.gnu.org id=B17777.14028056551726 (code B ref 17777); Sun, 15 Jun 2014 04:15:03 +0000 Original-Received: (at 17777) by debbugs.gnu.org; 15 Jun 2014 04:14:15 +0000 Original-Received: from localhost ([127.0.0.1]:48121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ww1pe-0000Rm-Rf for submit@debbugs.gnu.org; Sun, 15 Jun 2014 00:14:15 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:60937) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ww1pc-0000RZ-An for 17777@debbugs.gnu.org; Sun, 15 Jun 2014 00:14:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBJy8jEAs0BwsUGA0kiAQI0hkXjnoHhDgBA5RijliFX4FqgXGBWyE X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBJy8jEAs0BwsUGA0kiAQI0hkXjnoHhDgBA5RijliFX4FqgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="66901478" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 15 Jun 2014 00:14:06 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 7ED85660D3; Sun, 15 Jun 2014 00:14:06 -0400 (EDT) In-Reply-To: <83tx7mvqhn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 15 Jun 2014 05:47:00 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90397 Archived-At: >> > if (w->window_end_valid >> > + && NILP (Vexecuting_kbd_macro) >> > && !windows_or_buffers_changed >> > && b >> > && !b->clip_changed >> NILP (Vexecuting_kbd_macro) seems like a workaround. > It isn't. >> Why can't the glyph matrix be used in this case? > Because cursor position is not up-to-date in that case. >> I means which part of the glyph matrix is wrong in the OP's recipe >> (since this makes no change to the buffer)? > The cursor position. But that can occur even without executing kbd macros, no? Wouldn't it be better to ignore the cursor position given in the glyph matrix and use (point) instead? Stefan