unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 17777@debbugs.gnu.org
Subject: bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement.
Date: Sun, 15 Jun 2014 00:14:06 -0400	[thread overview]
Message-ID: <jwv8uoy95f3.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <83tx7mvqhn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 15 Jun 2014 05:47:00 +0300")

>> >    if (w->window_end_valid
>> > +      && NILP (Vexecuting_kbd_macro)
>> >        && !windows_or_buffers_changed
>> >        && b
>> >        && !b->clip_changed
>> NILP (Vexecuting_kbd_macro) seems like a workaround.
> It isn't.
>> Why can't the glyph matrix be used in this case?
> Because cursor position is not up-to-date in that case.
>> I means which part of the glyph matrix is wrong in the OP's recipe
>> (since this makes no change to the buffer)?
> The cursor position.

But that can occur even without executing kbd macros, no?
Wouldn't it be better to ignore the cursor position given in the glyph
matrix and use (point) instead?


        Stefan





  reply	other threads:[~2014-06-15  4:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1WvlrC-0007Ya-Lc@vcs.savannah.gnu.org>
2014-06-14 21:06 ` bug#17777: [Emacs-diffs] emacs-24 r117241: Fix bug #17777 with keyboard macros and visual-order cursor movement Stefan Monnier
2014-06-15  2:47   ` Eli Zaretskii
2014-06-15  4:14     ` Stefan Monnier [this message]
2014-06-15 16:12       ` Eli Zaretskii
2014-06-16 19:40         ` Eli Zaretskii
2014-06-16 21:50           ` Stefan Monnier
2014-06-16 21:28         ` Stefan Monnier
2014-06-17  2:46           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8uoy95f3.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17777@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).