unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 17947@debbugs.gnu.org, ethan.glasser.camp@gmail.com
Subject: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally
Date: Sat, 05 Jul 2014 19:02:05 -0400	[thread overview]
Message-ID: <jwv8uo7za0i.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83fvifehjh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Jul 2014 22:23:30 +0300")

>> > One user reported that ruby-mode triggers this warning. Sure enough, in
>> > ruby-mode.el at line 287, I see:
>> >   (set (make-local-variable 'require-final-newline) t)
>> Removed in the `emacs-24' branch.
> Regardless of what this or that mode does, I think it's wrong for
> ethan-wspace to annoy users for having require-final-newline set
> non-nil.

It's his package and he's free to do what he wants with it, I think.
Maybe I'd find it annoying as well, but in any case the setting was
erroneous since there is no justification to ignore the
mode-require-final-newline setting.


        Stefan





  reply	other threads:[~2014-07-05 23:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-05 18:07 bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally Ethan Glasser-Camp
2014-07-05 18:11 ` Eli Zaretskii
2014-07-05 18:19   ` Ethan
2014-07-05 18:38     ` Eli Zaretskii
2014-07-05 18:38 ` Stefan Monnier
2014-07-05 19:23   ` Eli Zaretskii
2014-07-05 23:02     ` Stefan Monnier [this message]
2014-07-06  2:45       ` Eli Zaretskii
2014-07-06  4:27         ` Ethan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8uo7za0i.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17947@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=ethan.glasser.camp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).