From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18399: 24.4.50; nadvice :filter-args -vs- interactive Date: Wed, 03 Sep 2014 22:59:14 -0400 Message-ID: References: <87mwagbhim.fsf@tromey.com> <87zjegh1wj.fsf@web.de> <87iol4baqs.fsf@tromey.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1409799630 31017 80.91.229.3 (4 Sep 2014 03:00:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Sep 2014 03:00:30 +0000 (UTC) Cc: Michael Heerdegen , 18399@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 04 05:00:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XPNHa-0002JC-CY for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Sep 2014 05:00:22 +0200 Original-Received: from localhost ([::1]:48566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPNHa-0002kc-2t for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Sep 2014 23:00:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPNHP-0002jU-Ht for bug-gnu-emacs@gnu.org; Wed, 03 Sep 2014 23:00:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPNHI-0001nm-1H for bug-gnu-emacs@gnu.org; Wed, 03 Sep 2014 23:00:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPNHH-0001mw-Um for bug-gnu-emacs@gnu.org; Wed, 03 Sep 2014 23:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XPNHG-0007Mg-Qo for bug-gnu-emacs@gnu.org; Wed, 03 Sep 2014 23:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Sep 2014 03:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 18399-submit@debbugs.gnu.org id=B18399.140979956228233 (code B ref 18399); Thu, 04 Sep 2014 03:00:02 +0000 Original-Received: (at 18399) by debbugs.gnu.org; 4 Sep 2014 02:59:22 +0000 Original-Received: from localhost ([127.0.0.1]:58279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPNGb-0007LI-W3 for submit@debbugs.gnu.org; Wed, 03 Sep 2014 22:59:22 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:48242) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPNGY-0007L9-VV for 18399@debbugs.gnu.org; Wed, 03 Sep 2014 22:59:19 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s842xFFZ003032; Wed, 3 Sep 2014 22:59:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id BE0A86308B; Wed, 3 Sep 2014 22:59:14 -0400 (EDT) In-Reply-To: <87iol4baqs.fsf@tromey.com> (Tom Tromey's message of "Wed, 03 Sep 2014 16:27:39 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5053=0 X-NAI-Spam-Version: 2.3.0.9378 : core <5053> : inlines <1238> : streams <1280884> : uri <1810074> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93014 Archived-At: Michael> According to the doc (of `add-function'), an filter-args advice Michael> function has to accept exactly one argument (which is bound to Michael> the list of given arguments). So I think what you see is Michael> expected. Michael> I have stumbled over that behavior several times myself. > I looked at the docs again and I agree. Sorry about the noise. Perhaps > a note and/or a small example here would be nice for future users. If > we were both fooled by this then perhaps others will be as well. FWIW, the use of a single formal arg receiving the actual arg-list in :filter-args is based on performance reasons (we have the list anyway, so it's more efficient to pass it to `funcall' than to `apply'). Stefan