From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Tom Tromey <tom@tromey.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 18399@debbugs.gnu.org
Subject: bug#18399: 24.4.50; nadvice :filter-args -vs- interactive
Date: Wed, 03 Sep 2014 22:59:14 -0400 [thread overview]
Message-ID: <jwv8um0xfdu.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87iol4baqs.fsf@tromey.com> (Tom Tromey's message of "Wed, 03 Sep 2014 16:27:39 -0600")
Michael> According to the doc (of `add-function'), an filter-args advice
Michael> function has to accept exactly one argument (which is bound to
Michael> the list of given arguments). So I think what you see is
Michael> expected.
Michael> I have stumbled over that behavior several times myself.
> I looked at the docs again and I agree. Sorry about the noise. Perhaps
> a note and/or a small example here would be nice for future users. If
> we were both fooled by this then perhaps others will be as well.
FWIW, the use of a single formal arg receiving the actual arg-list
in :filter-args is based on performance reasons (we have the list
anyway, so it's more efficient to pass it to `funcall' than to `apply').
Stefan
next prev parent reply other threads:[~2014-09-04 2:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 20:01 bug#18399: 24.4.50; nadvice :filter-args -vs- interactive Tom Tromey
2014-09-03 20:42 ` Michael Heerdegen
2014-09-03 22:27 ` Tom Tromey
2014-09-04 2:59 ` Stefan Monnier [this message]
2014-09-04 13:13 ` Stefan Monnier
2014-09-04 15:44 ` Stefan Monnier
2014-09-04 23:11 ` Michael Heerdegen
2014-09-05 1:24 ` Stefan Monnier
2014-09-05 16:29 ` Michael Heerdegen
2014-09-06 5:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8um0xfdu.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=18399@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).