From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30635: No compiler warning if code forgets to require cl-lib Date: Mon, 19 Mar 2018 15:58:48 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521489428 634 195.159.176.226 (19 Mar 2018 19:57:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Mar 2018 19:57:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30635@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 19 20:57:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey0tz-0008Vr-SL for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Mar 2018 20:57:03 +0100 Original-Received: from localhost ([::1]:43646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey0w3-00066y-6A for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Mar 2018 15:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey0vx-00066n-6R for bug-gnu-emacs@gnu.org; Mon, 19 Mar 2018 15:59:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey0vu-0003s0-2E for bug-gnu-emacs@gnu.org; Mon, 19 Mar 2018 15:59:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34310) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ey0vt-0003ru-UL for bug-gnu-emacs@gnu.org; Mon, 19 Mar 2018 15:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ey0vt-0001st-K2 for bug-gnu-emacs@gnu.org; Mon, 19 Mar 2018 15:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Mar 2018 19:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30635-submit@debbugs.gnu.org id=B30635.15214895307225 (code B ref 30635); Mon, 19 Mar 2018 19:59:01 +0000 Original-Received: (at 30635) by debbugs.gnu.org; 19 Mar 2018 19:58:50 +0000 Original-Received: from localhost ([127.0.0.1]:42207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey0vi-0001sT-As for submit@debbugs.gnu.org; Mon, 19 Mar 2018 15:58:50 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:42415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey0vh-0001sM-8w for 30635@debbugs.gnu.org; Mon, 19 Mar 2018 15:58:49 -0400 Original-Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2JJwmM5023403; Mon, 19 Mar 2018 15:58:48 -0400 Original-Received: by lechazo.home (Postfix, from userid 20848) id 3E4AF632A7; Mon, 19 Mar 2018 15:58:48 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Tue, 27 Feb 2018 13:45:57 -0500") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6245=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6245> : inlines <6504> : streams <1781677> : uri <2611215> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144421 Archived-At: > There's no compiler warning if a library uses cl-lib without requiring it. > I assume this is because bytecomp.el requires cl-lib. Should we apply the patch below? Stefan diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index b3ea9300b0..e75403d80d 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -124,17 +124,11 @@ (require 'backquote) (require 'macroexp) (require 'cconv) -(require 'cl-lib) - -;; During bootstrap, cl-loaddefs.el is not created yet, so loading cl-lib -;; doesn't setup autoloads for things like cl-every, which is why we have to -;; require cl-extra as well (bug#18804). -(or (fboundp 'cl-every) - (require 'cl-extra)) - -(or (fboundp 'defsubst) - ;; This really ought to be loaded already! - (load "byte-run")) +(eval-when-compile + ;; We should refrain from loading cl-lib at run-time within the compiler + ;; code, otherwise we can't detect if a file forgets to (require 'cl-lib), + ;; as mentioned in bug#30635. + (require 'cl-lib)) ;; The feature of compiling in a specific target Emacs version ;; has been turned off because compile time options are a bad idea. @@ -3582,7 +3576,10 @@ byte-compile-and-folded (cond ((< l 3) (byte-compile-form `(progn ,(nth 1 form) t))) ((= l 3) (byte-compile-two-args form)) - ((cl-every #'macroexp-copyable-p (nthcdr 2 form)) + ;; This used to use `cl-every' but we need to avoid cl-lib at run-time as + ;; mentioned at the beginning of this file. + ((null (delq nil (mapcar (lambda (e) (not (macroexp-copyable-p e))) + (nthcdr 2 form)))) (byte-compile-form `(and (,(car form) ,(nth 1 form) ,(nth 2 form)) (,(car form) ,@(nthcdr 2 form))))) (t (byte-compile-normal-call form)))))