From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#39842: [PATCH] Use help-fns-short-filename in other describe- commands Date: Sat, 29 Feb 2020 15:02:05 -0500 Message-ID: References: <20200229190008.338460-1-stepnem@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="14489"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39842@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 29 21:03:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j88Ke-0003g1-B5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Feb 2020 21:03:28 +0100 Original-Received: from localhost ([::1]:35442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j88Kd-0000yt-Ds for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Feb 2020 15:03:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46776) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j88KG-0000yV-Fa for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:03:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j88KE-0004AA-Mk for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:03:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j88KD-0004A2-QI for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j88KD-00068k-Mj for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Feb 2020 20:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39842 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158300653323537 (code B ref -1); Sat, 29 Feb 2020 20:03:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Feb 2020 20:02:13 +0000 Original-Received: from localhost ([127.0.0.1]:35436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j88JR-00067Z-Fe for submit@debbugs.gnu.org; Sat, 29 Feb 2020 15:02:13 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:44071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j88JQ-00067S-Qc for submit@debbugs.gnu.org; Sat, 29 Feb 2020 15:02:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46674) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j88JP-0000uU-NQ for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:02:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j88JO-0003Vu-4A for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:02:10 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37244) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j88JO-0003U5-0A for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:02:10 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 28FA6814E0; Sat, 29 Feb 2020 15:02:09 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 76ED9810E8; Sat, 29 Feb 2020 15:02:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1583006527; bh=QMvu9NQcVl9NXSCSRp94VvBI51mYAC2P0yzAad5MtRM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ia4/MYz+/VDf5qhxXPVzWFjMcNydgVWYz7BdEieL4DE+tAn0XBbNkLH9DkxkahM7L xHEMrKgObJtaA6JX76EFY53KDZT/STyM8oX/cgE68+eSpF6r9naSUO9ThPOQtWkWV/ BQgPGhLrZMedTw3E6UFiUYmrh6bytFTG8dVD6+ZKj94unD8cYpgavLQheP1rzeS8Mv Xfmzb4hrP2jxLLtRS1C9XVvuOY4yktBZztU8pC/gr4NdMhqJiqP8kzMo0hsNtgC39M aUmrrsoOML7KSQz4bqnktzZEx9ffCzhQhqJwwSkIok8xZJ/7urH9CxmZNeuVstoTRP XeedVttiGKJkQ== Original-Received: from pastel (unknown [216.154.50.221]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E21C71203B9; Sat, 29 Feb 2020 15:02:06 -0500 (EST) In-Reply-To: <20200229190008.338460-1-stepnem@gmail.com> ("=?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?="'s message of "Sat, 29 Feb 2020 20:00:08 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176690 Archived-At: > Make the other help commands use it, too. Sounds good. See a few comments below. > +;;;###autoload > (defun help-fns-short-filename (filename) OK, we can live that. Maybe, moving it to help.el would be a cleaner option. > index 45cbaad4e8..32204d04e3 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -879,6 +879,7 @@ describe-key > (princ ", which is ") > (describe-function-1 defn))))))) > > +(declare-function help-fns-short-filename "help-fns" (filename)) > (defun describe-mode (&optional buffer) > "Display documentation of current major mode and minor modes. > A brief summary of the minor modes comes first, followed by the The autoload cookie above should render this `declare-function` unnecessary, right? Stefan