From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Tue, 04 Jul 2023 16:36:01 -0400 Message-ID: References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> <831qhwx5qf.fsf@gnu.org> <87zg4k76es.fsf@orphne.orion.oneofus.la> <83mt0jvmfu.fsf@gnu.org> <87r0pva66g.fsf@t510.orion.oneofus.la> <834jmrv3p6.fsf@gnu.org> <87o7kz9wej.fsf@t510.orion.oneofus.la> <83wmzmuaq7.fsf@gnu.org> <87wmzmb5fl.fsf@t510.orion.oneofus.la> <83a5wita0p.fsf@gnu.org> <87ttuqax6d.fsf@t510.orion.oneofus.la> <835y75tsn7.fsf@gnu.org> <87r0ps7v92.fsf@t510.orion.oneofus.la> <831qhqq0kf.fsf@gnu.org> <837crfll1t.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64311@debbugs.gnu.org, vas@oneofus.la To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 04 22:37:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGmlv-000AXD-Qu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jul 2023 22:37:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGmll-0002Kk-Ds; Tue, 04 Jul 2023 16:37:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGmli-0002Ka-Ra for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 16:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGmli-0004tN-Is for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 16:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGmli-0001Y9-0D for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 16:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2023 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.16885029755888 (code B ref 64311); Tue, 04 Jul 2023 20:37:01 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 4 Jul 2023 20:36:15 +0000 Original-Received: from localhost ([127.0.0.1]:36689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGmkx-0001Wu-0i for submit@debbugs.gnu.org; Tue, 04 Jul 2023 16:36:15 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGmks-0001WV-CZ for 64311@debbugs.gnu.org; Tue, 04 Jul 2023 16:36:13 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 124EC4425E4; Tue, 4 Jul 2023 16:36:05 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 981104425DA; Tue, 4 Jul 2023 16:36:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688502963; bh=74wF3Jdj7ce8IfzOIRRPHKR8svmrxlA4Kmpw+pZ420g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ksGizQPEcTaSfX+SMuRwLBhOsbVyk+8UJdf8eSf4BKg/4ifvzHmbNA7SK35GH5W97 1UbwqwSbersb5xkLC/lt63lJmzBg5fLyoVsPS/l3maCKNQPXs9xKDBLbh2cVsG0ycB yQ4WNtdtlQMfiydM6JKmuqDDPcHYvt/mFhMFi8MMwXID+9Iqrb7GZitmiB0cK1yW/E Hh4+U6Ss6T5RqpTXlJl8lYl1Mn2GAMxQgkqLmAzzvaxJn1KRXy5u7xR8KACJUgfX6l 4ixCXbvHCi0Knl1vd6x6rGOHVtaAo2eA5zpS4iPoFRi+ADBsI8trswUnixbQmiRuV8 kEhocXX/N4/XQ== Original-Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6DE6E1202A5; Tue, 4 Jul 2023 16:36:03 -0400 (EDT) In-Reply-To: <837crfll1t.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 04 Jul 2023 19:05:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264606 Archived-At: >> FWIW, my take on the root cause is that I made a mistake in commit >> 05327ca9724287cc3da4c625f180da5ab11be998 where I forgot to remove the >> `defvar` of `shell-dirtrackp` (and I swapped the args to `defvaralias`). > > The problem here for me is that this mistake was made long ago, and by > now there could be people out there who actually rely on this > problematic alias. None of the patches I've seen remove the alias, AFAICT. Some reverse the direction but I'm hard pressed to imagine a way for code to be affected by this (unless they call `indirect-variable`, obviously). > The original patch makes a backward-incompatible change, which for me > is a significant disadvantage. I don't know what backward-incompatible you're referring to. Stefan